From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 1F7FC1382C5 for ; Thu, 23 Jun 2016 11:26:50 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 3D5A314209; Thu, 23 Jun 2016 11:26:41 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 0CBF71418A for ; Thu, 23 Jun 2016 11:26:39 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id CFDEF340B7E for ; Thu, 23 Jun 2016 11:26:37 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 717BE2421 for ; Thu, 23 Jun 2016 11:26:35 +0000 (UTC) From: "Alexis Ballier" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Alexis Ballier" Message-ID: <1466681006.0129041f2c723e5efafb5013cc09fb63218be65f.aballier@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: dev-ml/ocamlnet/ X-VCS-Repository: repo/gentoo X-VCS-Files: dev-ml/ocamlnet/ocamlnet-3.7.7.ebuild dev-ml/ocamlnet/ocamlnet-4.0.4.ebuild dev-ml/ocamlnet/ocamlnet-4.1.1.ebuild X-VCS-Directories: dev-ml/ocamlnet/ X-VCS-Committer: aballier X-VCS-Committer-Name: Alexis Ballier X-VCS-Revision: 0129041f2c723e5efafb5013cc09fb63218be65f X-VCS-Branch: master Date: Thu, 23 Jun 2016 11:26:35 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: deb00715-5462-472a-9e23-176ea46c3cff X-Archives-Hash: e90e70d22ddb8b36c8c6ae81ab3174e3 commit: 0129041f2c723e5efafb5013cc09fb63218be65f Author: Alexis Ballier gentoo org> AuthorDate: Thu Jun 23 09:00:13 2016 +0000 Commit: Alexis Ballier gentoo org> CommitDate: Thu Jun 23 11:23:26 2016 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0129041f Revert "dev-ml/ocamlnet: Remove another := slot op from || dep" This reverts commit 3b1a4cc0f9b9a0a2c70d6bb53cb71bf059e2920e. This commit is wrong in several aspects: - Such changes should come with a revbump - Removing := deps causes packages not to be rebuilt on upgrades, causing barely understandable build failures when upgrading, later on. Thanks to this commit, people that have installed those packages will likely experience those failures with the upcoming ocaml 4.03 unmask. - This is a non maintainer commit where no discussion at all happened with the maintainers during the 3 days between bug report and mass commit. Such discussion could have prevented the above mentioned breakage. Proper fix is to drop the backward compatibility part of the || () dep. This fix was slowly moving forward whenever possible and noticed. Main blocker for this is bug #463018 which requires taking extra care for not breaking the stable tree nor needlessly preventing future stabilization of packages. dev-ml/ocamlnet/ocamlnet-3.7.7.ebuild | 2 +- dev-ml/ocamlnet/ocamlnet-4.0.4.ebuild | 2 +- dev-ml/ocamlnet/ocamlnet-4.1.1.ebuild | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dev-ml/ocamlnet/ocamlnet-3.7.7.ebuild b/dev-ml/ocamlnet/ocamlnet-3.7.7.ebuild index 61ad3d6..779f710 100644 --- a/dev-ml/ocamlnet/ocamlnet-3.7.7.ebuild +++ b/dev-ml/ocamlnet/ocamlnet-3.7.7.ebuild @@ -23,7 +23,7 @@ RESTRICT="installsources" DEPEND=">=dev-ml/findlib-1.0 pcre? ( >=dev-ml/pcre-ocaml-5:= ) >=dev-lang/ocaml-3.10.2:=[ocamlopt?] - tk? ( || ( dev-ml/labltk =dev-ml/lablgtk-2:= ) ssl? ( >=dev-ml/ocaml-ssl-0.4:= ) diff --git a/dev-ml/ocamlnet/ocamlnet-4.0.4.ebuild b/dev-ml/ocamlnet/ocamlnet-4.0.4.ebuild index db254b6..5fe2f7a 100644 --- a/dev-ml/ocamlnet/ocamlnet-4.0.4.ebuild +++ b/dev-ml/ocamlnet/ocamlnet-4.0.4.ebuild @@ -23,7 +23,7 @@ RESTRICT="installsources" RDEPEND=">=dev-ml/findlib-1.0 pcre? ( >=dev-ml/pcre-ocaml-5:= ) >=dev-lang/ocaml-3.10.2:=[ocamlopt?] - tk? ( || ( dev-ml/labltk =dev-ml/lablgtk-2:= ) kerberos? ( virtual/krb5 ) diff --git a/dev-ml/ocamlnet/ocamlnet-4.1.1.ebuild b/dev-ml/ocamlnet/ocamlnet-4.1.1.ebuild index dc77608..5c042a3 100644 --- a/dev-ml/ocamlnet/ocamlnet-4.1.1.ebuild +++ b/dev-ml/ocamlnet/ocamlnet-4.1.1.ebuild @@ -23,7 +23,7 @@ RESTRICT="installsources" RDEPEND=">=dev-ml/findlib-1.0 pcre? ( >=dev-ml/pcre-ocaml-5:= ) >=dev-lang/ocaml-3.10.2:=[ocamlopt?] - tk? ( || ( dev-ml/labltk =dev-ml/lablgtk-2:= ) kerberos? ( virtual/krb5 )