From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 7463C1382C5 for ; Thu, 23 Jun 2016 11:26:43 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 798631420D; Thu, 23 Jun 2016 11:26:40 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 89EA3141F9 for ; Thu, 23 Jun 2016 11:26:39 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 433E3340B7F for ; Thu, 23 Jun 2016 11:26:38 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 4D5AE241F for ; Thu, 23 Jun 2016 11:26:35 +0000 (UTC) From: "Alexis Ballier" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Alexis Ballier" Message-ID: <1466681003.4c5e801495b57bfcf580f8d3192699f599722bdc.aballier@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: dev-util/coccinelle/ X-VCS-Repository: repo/gentoo X-VCS-Files: dev-util/coccinelle/coccinelle-1.0.0.ebuild dev-util/coccinelle/coccinelle-1.0.1.ebuild dev-util/coccinelle/coccinelle-1.0.2.ebuild dev-util/coccinelle/coccinelle-1.0.4.ebuild X-VCS-Directories: dev-util/coccinelle/ X-VCS-Committer: aballier X-VCS-Committer-Name: Alexis Ballier X-VCS-Revision: 4c5e801495b57bfcf580f8d3192699f599722bdc X-VCS-Branch: master Date: Thu, 23 Jun 2016 11:26:35 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: 2ad19ddf-7f73-424c-ba25-4585f793153d X-Archives-Hash: 57203d000a8339ea4afda9f6ee96b613 commit: 4c5e801495b57bfcf580f8d3192699f599722bdc Author: Alexis Ballier gentoo org> AuthorDate: Thu Jun 23 08:59:06 2016 +0000 Commit: Alexis Ballier gentoo org> CommitDate: Thu Jun 23 11:23:23 2016 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4c5e8014 Revert "dev-util/coccinelle: Remove := op from || dep, #586304" This reverts commit 23c0a5e66e44e35d9854ee94dc0e3b41a2f15035. This commit is wrong in several aspects: - Such changes should come with a revbump - Removing := deps causes packages not to be rebuilt on upgrades, causing barely understandable build failures when upgrading, later on. Thanks to this commit, people that have installed those packages will likely experience those failures with the upcoming ocaml 4.03 unmask. - This is a non maintainer commit where no discussion at all happened with the maintainers during the 3 days between bug report and mass commit. Such discussion could have prevented the above mentioned breakage. Proper fix is to drop the backward compatibility part of the || () dep. This fix was slowly moving forward whenever possible and noticed. Main blocker for this is bug #463018 which requires taking extra care for not breaking the stable tree nor needlessly preventing future stabilization of packages. dev-util/coccinelle/coccinelle-1.0.0.ebuild | 4 ++-- dev-util/coccinelle/coccinelle-1.0.1.ebuild | 4 ++-- dev-util/coccinelle/coccinelle-1.0.2.ebuild | 4 ++-- dev-util/coccinelle/coccinelle-1.0.4.ebuild | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/dev-util/coccinelle/coccinelle-1.0.0.ebuild b/dev-util/coccinelle/coccinelle-1.0.0.ebuild index 40022f0..f7b4292 100644 --- a/dev-util/coccinelle/coccinelle-1.0.0.ebuild +++ b/dev-util/coccinelle/coccinelle-1.0.0.ebuild @@ -1,4 +1,4 @@ -# Copyright 1999-2016 Gentoo Foundation +# Copyright 1999-2015 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 # $Id$ @@ -22,7 +22,7 @@ REQUIRED_USE="${PYTHON_REQUIRED_USE}" CDEPEND=">=dev-lang/ocaml-3.12:=[ocamlopt?] dev-ml/sexplib:=[ocamlopt?] dev-ml/menhir:=[ocamlopt?] - || ( dev-ml/camlp4[ocamlopt?]