From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id DED821388BF for ; Wed, 6 Jan 2016 04:22:11 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B262C21C00D; Wed, 6 Jan 2016 04:21:57 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id E94CD21C006 for ; Wed, 6 Jan 2016 04:21:55 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 92CFB340A74 for ; Wed, 6 Jan 2016 04:21:54 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id E40D4D22 for ; Wed, 6 Jan 2016 04:21:51 +0000 (UTC) From: "Brian Dolbec" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Brian Dolbec" Message-ID: <1452053303.a490f6e830d263a9ce055c61bd4e794943204e09.dolsen@gentoo> Subject: [gentoo-commits] proj/portage:repoman commit in: pym/repoman/modules/scan/depend/, pym/repoman/ X-VCS-Repository: proj/portage X-VCS-Files: pym/repoman/modules/scan/depend/depend.py pym/repoman/scanner.py X-VCS-Directories: pym/repoman/modules/scan/depend/ pym/repoman/ X-VCS-Committer: dolsen X-VCS-Committer-Name: Brian Dolbec X-VCS-Revision: a490f6e830d263a9ce055c61bd4e794943204e09 X-VCS-Branch: repoman Date: Wed, 6 Jan 2016 04:21:51 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: a4009def-30ea-4ac3-b667-9f016c73615c X-Archives-Hash: 6bf8801b01b90190929f4b97cab03a45 commit: a490f6e830d263a9ce055c61bd4e794943204e09 Author: Brian Dolbec gentoo org> AuthorDate: Sun Jan 3 21:19:59 2016 +0000 Commit: Brian Dolbec gentoo org> CommitDate: Wed Jan 6 04:08:23 2016 +0000 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=a490f6e8 repoman: Migrate some additional Dependency code to the plugin pym/repoman/modules/scan/depend/depend.py | 13 ++++++++++++- pym/repoman/scanner.py | 16 +++------------- 2 files changed, 15 insertions(+), 14 deletions(-) diff --git a/pym/repoman/modules/scan/depend/depend.py b/pym/repoman/modules/scan/depend/depend.py index 8a0ff48..7f1d007 100644 --- a/pym/repoman/modules/scan/depend/depend.py +++ b/pym/repoman/modules/scan/depend/depend.py @@ -1,3 +1,5 @@ +# -*- coding:utf-8 -*- + from _emerge.Package import Package @@ -121,7 +123,16 @@ class DependChecks(object): qacat = m + ".syntax" self.qatracker.add_error( qacat, "%s: %s: %s" % (ebuild.relative_path, m, b)) - return {'continue': False, 'unknown_pkgs': unknown_pkgs, 'type_list': type_list} + + # data required for some other tests + badlicsyntax = len([z for z in type_list if z == "LICENSE"]) + badprovsyntax = len([z for z in type_list if z == "PROVIDE"]) + baddepsyntax = len(type_list) != badlicsyntax + badprovsyntax + badlicsyntax = badlicsyntax > 0 + #badprovsyntax = badprovsyntax > 0 + + return {'continue': False, 'unknown_pkgs': unknown_pkgs, 'type_list': type_list, + 'badlicsyntax': badlicsyntax, 'baddepsyntax': baddepsyntax} @property def runInPkgs(self): diff --git a/pym/repoman/scanner.py b/pym/repoman/scanner.py index 11f7d93..2b0a748 100644 --- a/pym/repoman/scanner.py +++ b/pym/repoman/scanner.py @@ -331,21 +331,11 @@ class Scanner(object): print("**** finished plugin loop, continuing...") - baddepsyntax = False - badlicsyntax = False - badprovsyntax = False - # catpkg = catdir + "/" + y_ebuild - - badlicsyntax = len([z for z in dynamic_data['type_list'] if z == "LICENSE"]) - badprovsyntax = len([z for z in dynamic_data['type_list'] if z == "PROVIDE"]) - baddepsyntax = len(dynamic_data['type_list']) != badlicsyntax + badprovsyntax - badlicsyntax = badlicsyntax > 0 - badprovsyntax = badprovsyntax > 0 used_useflags = used_useflags.union(dynamic_data['ebuild_UsedUseFlags']) # license checks - if not badlicsyntax: + if not dynamic_data['badlicsyntax']: self.licensecheck.check(dynamic_data['pkg'], xpkg, dynamic_data['ebuild'], y_ebuild) self.restrictcheck.check(dynamic_data['pkg'], xpkg, dynamic_data['ebuild'], y_ebuild) @@ -451,7 +441,7 @@ class Scanner(object): dep_settings.usemask = dep_settings._use_manager.getUseMask( dynamic_data['pkg'], stable=dep_settings._parent_stable) - if not baddepsyntax: + if not dynamic_data['baddepsyntax']: ismasked = not dynamic_data['ebuild'].archs or \ dynamic_data['pkg'].cpv not in self.portdb.xmatch("match-visible", Atom("%s::%s" % (dynamic_data['pkg'].cp, self.repo_settings.repo_config.name))) @@ -541,7 +531,7 @@ class Scanner(object): % (dynamic_data['ebuild'].relative_path, mytype, keyword, prof, pformat(atoms, indent=6))) - if not baddepsyntax and dynamic_data['unknown_pkgs']: + if not dynamic_data['baddepsyntax'] and dynamic_data['unknown_pkgs']: type_map = {} for mytype, atom in dynamic_data['unknown_pkgs']: type_map.setdefault(mytype, set()).add(atom)