public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Mike Gilbert" <floppym@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: sys-boot/grub/files/
Date: Fri, 18 Dec 2015 17:01:16 +0000 (UTC)	[thread overview]
Message-ID: <1450458047.27cb6e8ce5f9c2faea0b4a39887d5d937b6107ef.floppym@gentoo> (raw)

commit:     27cb6e8ce5f9c2faea0b4a39887d5d937b6107ef
Author:     Mike Gilbert <floppym <AT> gentoo <DOT> org>
AuthorDate: Fri Dec 18 17:00:47 2015 +0000
Commit:     Mike Gilbert <floppym <AT> gentoo <DOT> org>
CommitDate: Fri Dec 18 17:00:47 2015 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=27cb6e8c

sys-boot/grub: Replace patch for CVE-2015-8370

Use what actually got accepted upstream.

Package-Manager: portage-2.2.26_p32

 sys-boot/grub/files/CVE-2015-8370.patch | 57 +++++++++++++++++++--------------
 1 file changed, 33 insertions(+), 24 deletions(-)

diff --git a/sys-boot/grub/files/CVE-2015-8370.patch b/sys-boot/grub/files/CVE-2015-8370.patch
index 5701b54..69e419e 100644
--- a/sys-boot/grub/files/CVE-2015-8370.patch
+++ b/sys-boot/grub/files/CVE-2015-8370.patch
@@ -1,45 +1,54 @@
-From 88c9657960a6c5d3673a25c266781e876c181add Mon Sep 17 00:00:00 2001
+From 451d80e52d851432e109771bb8febafca7a5f1f2 Mon Sep 17 00:00:00 2001
 From: Hector Marco-Gisbert <hecmargi@upv.es>
-Date: Fri, 13 Nov 2015 16:21:09 +0100
+Date: Wed, 16 Dec 2015 07:57:18 +0300
 Subject: [PATCH] Fix security issue when reading username and password
 
-  This patch fixes two integer underflows at:
-    * grub-core/lib/crypto.c
-    * grub-core/normal/auth.c
+This patch fixes two integer underflows at:
+  * grub-core/lib/crypto.c
+  * grub-core/normal/auth.c
+
+CVE-2015-8370
 
 Signed-off-by: Hector Marco-Gisbert <hecmargi@upv.es>
 Signed-off-by: Ismael Ripoll-Ripoll <iripoll@disca.upv.es>
+Also-By: Andrey Borzenkov <arvidjaar@gmail.com>
 ---
- grub-core/lib/crypto.c  | 2 +-
- grub-core/normal/auth.c | 2 +-
- 2 files changed, 2 insertions(+), 2 deletions(-)
+ grub-core/lib/crypto.c  | 3 ++-
+ grub-core/normal/auth.c | 7 +++++--
+ 2 files changed, 7 insertions(+), 3 deletions(-)
 
 diff --git a/grub-core/lib/crypto.c b/grub-core/lib/crypto.c
-index 010e550..524a3d8 100644
+index 010e550..683a8aa 100644
 --- a/grub-core/lib/crypto.c
 +++ b/grub-core/lib/crypto.c
-@@ -468,7 +468,7 @@ grub_password_get (char buf[], unsigned buf_size)
- 	  break;
- 	}
+@@ -470,7 +470,8 @@ grub_password_get (char buf[], unsigned buf_size)
  
--      if (key == '\b')
-+      if (key == '\b' && cur_len)
+       if (key == '\b')
  	{
- 	  cur_len--;
+-	  cur_len--;
++	  if (cur_len)
++	    cur_len--;
  	  continue;
+ 	}
+ 
 diff --git a/grub-core/normal/auth.c b/grub-core/normal/auth.c
-index c6bd96e..5782ec5 100644
+index c6bd96e..8615c48 100644
 --- a/grub-core/normal/auth.c
 +++ b/grub-core/normal/auth.c
-@@ -172,7 +172,7 @@ grub_username_get (char buf[], unsigned buf_size)
- 	  break;
- 	}
+@@ -174,8 +174,11 @@ grub_username_get (char buf[], unsigned buf_size)
  
--      if (key == '\b')
-+      if (key == '\b' && cur_len)
+       if (key == '\b')
  	{
- 	  cur_len--;
- 	  grub_printf ("\b");
+-	  cur_len--;
+-	  grub_printf ("\b");
++	  if (cur_len)
++	    {
++	      cur_len--;
++	      grub_printf ("\b");
++	    }
+ 	  continue;
+ 	}
+ 
 -- 
-1.9.1
+2.6.4
 


             reply	other threads:[~2015-12-18 17:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-18 17:01 Mike Gilbert [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-10-05 15:48 [gentoo-commits] repo/gentoo:master commit in: sys-boot/grub/files/ Mike Gilbert
2016-10-05 19:35 Mike Gilbert
2017-02-04 21:22 David Seifert
2017-08-13 11:31 David Seifert
2019-02-16 21:05 Lars Wendler
2020-02-14 11:02 Mikle Kolyada
2021-09-06  3:00 Mike Frysinger
2022-09-28 19:32 Mike Gilbert
2023-05-11 20:28 Conrad Kostecki
2024-01-20 21:22 Conrad Kostecki
2024-08-04 15:07 Mike Gilbert
2024-09-06 13:17 James Le Cuirot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1450458047.27cb6e8ce5f9c2faea0b4a39887d5d937b6107ef.floppym@gentoo \
    --to=floppym@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox