public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Alexis Ballier" <aballier@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: dev-ros/rviz/, dev-ros/rviz/files/
Date: Sat, 26 Sep 2015 09:50:20 +0000 (UTC)	[thread overview]
Message-ID: <1443261014.b3f1ee6b4589cfaad2e2224517aab46926d1da72.aballier@gentoo> (raw)

commit:     b3f1ee6b4589cfaad2e2224517aab46926d1da72
Author:     Alexis Ballier <aballier <AT> gentoo <DOT> org>
AuthorDate: Sat Sep 26 09:50:01 2015 +0000
Commit:     Alexis Ballier <aballier <AT> gentoo <DOT> org>
CommitDate: Sat Sep 26 09:50:14 2015 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b3f1ee6b

dev-ros/rviz: Fix build of python bindings if rviz was not previously installed. Bug #561480 by Eric Timmons.

Package-Manager: portage-2.2.22

 dev-ros/rviz/files/libdir.patch | 26 ++++++++++++++++++++++++++
 dev-ros/rviz/rviz-1.11.9.ebuild |  2 ++
 2 files changed, 28 insertions(+)

diff --git a/dev-ros/rviz/files/libdir.patch b/dev-ros/rviz/files/libdir.patch
new file mode 100644
index 0000000..9044ded
--- /dev/null
+++ b/dev-ros/rviz/files/libdir.patch
@@ -0,0 +1,26 @@
+https://github.com/ros-visualization/rviz/pull/922
+
+commit 2f93b132a63e25e3cece330ebaf16de7a8aa9517
+Author: Alexis Ballier <aballier@gentoo.org>
+Date:   Sat Sep 26 11:39:39 2015 +0200
+
+    python_bindings: sip: Use CATKIN_PACKAGE_LIB_DESTINATION instead of hardcoded lib.
+    
+    Fixes build with libdir != lib.
+    https://bugs.gentoo.org/show_bug.cgi?id=561480
+
+diff --git a/src/python_bindings/sip/CMakeLists.txt b/src/python_bindings/sip/CMakeLists.txt
+index 6b0c939..c91a6be 100644
+--- a/src/python_bindings/sip/CMakeLists.txt
++++ b/src/python_bindings/sip/CMakeLists.txt
+@@ -42,8 +42,8 @@ include(${python_qt_binding_EXTRAS_DIR}/sip_helper.cmake)
+ # maintain context for different named target
+ set(rviz_sip_INCLUDE_DIRS ${rviz_INCLUDE_DIRS} "${PROJECT_SOURCE_DIR}/src" ${catkin_INCLUDE_DIRS})
+ set(rviz_sip_LIBRARIES ${rviz_LIBRARIES} ${PROJECT_NAME})
+-set(rviz_sip_LIBRARY_DIRS ${rviz_LIBRARY_DIRS} ${CATKIN_DEVEL_PREFIX}/lib)
+-set(rviz_sip_LDFLAGS_OTHER ${rviz_LDFLAGS_OTHER} -Wl,-rpath,\\"${CATKIN_DEVEL_PREFIX}/lib\\")
++set(rviz_sip_LIBRARY_DIRS ${rviz_LIBRARY_DIRS} ${CATKIN_DEVEL_PREFIX}/${CATKIN_PACKAGE_LIB_DESTINATION})
++set(rviz_sip_LDFLAGS_OTHER ${rviz_LDFLAGS_OTHER} -Wl,-rpath,\\"${CATKIN_DEVEL_PREFIX}/${CATKIN_PACKAGE_LIB_DESTINATION}\\")
+ 
+ if(sip_helper_FOUND)
+   list(APPEND rviz_BINDINGS "sip")

diff --git a/dev-ros/rviz/rviz-1.11.9.ebuild b/dev-ros/rviz/rviz-1.11.9.ebuild
index 0bb062d..c801bb9 100644
--- a/dev-ros/rviz/rviz-1.11.9.ebuild
+++ b/dev-ros/rviz/rviz-1.11.9.ebuild
@@ -58,3 +58,5 @@ DEPEND="${RDEPEND}
 		dev-ros/rostest[${PYTHON_USEDEP}]
 		dev-cpp/gtest
 	)"
+
+PATCHES=( "${FILESDIR}/libdir.patch" )


             reply	other threads:[~2015-09-26  9:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-26  9:50 Alexis Ballier [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-03-24 11:18 [gentoo-commits] repo/gentoo:master commit in: dev-ros/rviz/, dev-ros/rviz/files/ Alexis Ballier
2016-10-20 12:12 Alexis Ballier
2016-10-20 12:12 Alexis Ballier
2021-08-11 10:58 Alexis Ballier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443261014.b3f1ee6b4589cfaad2e2224517aab46926d1da72.aballier@gentoo \
    --to=aballier@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox