public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Mike Frysinger" <vapier@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: net-firewall/ebtables/
Date: Wed, 23 Sep 2015 02:33:14 +0000 (UTC)	[thread overview]
Message-ID: <1442975584.244fec074ecb3fa9f3a9fc6cb50dab40acef59d1.vapier@gentoo> (raw)

commit:     244fec074ecb3fa9f3a9fc6cb50dab40acef59d1
Author:     Mike Frysinger <vapier <AT> gentoo <DOT> org>
AuthorDate: Tue Sep 22 23:02:16 2015 +0000
Commit:     Mike Frysinger <vapier <AT> gentoo <DOT> org>
CommitDate: Wed Sep 23 02:33:04 2015 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=244fec07

net-firewall/ebtables: delete incorrect/misleading comment

The quoted code is not safe at all, so delete the incorrect comment in
the hopes no one notices it and (incorrectly) copies it into a different
ebuild.

 net-firewall/ebtables/ebtables-2.0.10.4-r1.ebuild | 4 ----
 net-firewall/ebtables/ebtables-2.0.10.4.ebuild    | 4 ----
 2 files changed, 8 deletions(-)

diff --git a/net-firewall/ebtables/ebtables-2.0.10.4-r1.ebuild b/net-firewall/ebtables/ebtables-2.0.10.4-r1.ebuild
index e298706..a382ad6 100644
--- a/net-firewall/ebtables/ebtables-2.0.10.4-r1.ebuild
+++ b/net-firewall/ebtables/ebtables-2.0.10.4-r1.ebuild
@@ -42,10 +42,6 @@ src_compile() {
 	# This package uses _init functions to initialise extensions. With
 	# --as-needed this will not work.
 	append-ldflags $(no-as-needed)
-	# This package correctly aliases pointers, but gcc is unable to know that:
-	# unsigned char ip[4];
-	# if (*((uint32_t*)ip) == 0) {
-	#append-cflags -Wno-strict-aliasing
 	emake \
 		CC="$(tc-getCC)" \
 		CFLAGS="${CFLAGS}" \

diff --git a/net-firewall/ebtables/ebtables-2.0.10.4.ebuild b/net-firewall/ebtables/ebtables-2.0.10.4.ebuild
index 75eec73..b63cf5a 100644
--- a/net-firewall/ebtables/ebtables-2.0.10.4.ebuild
+++ b/net-firewall/ebtables/ebtables-2.0.10.4.ebuild
@@ -42,10 +42,6 @@ src_compile() {
 	# This package uses _init functions to initialise extensions. With
 	# --as-needed this will not work.
 	append-ldflags $(no-as-needed)
-	# This package correctly aliases pointers, but gcc is unable to know that:
-	# unsigned char ip[4];
-	# if (*((uint32_t*)ip) == 0) {
-	#append-cflags -Wno-strict-aliasing
 	emake \
 		CC="$(tc-getCC)" \
 		CFLAGS="${CFLAGS}" \


             reply	other threads:[~2015-09-23  2:33 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-23  2:33 Mike Frysinger [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-03-12 12:31 [gentoo-commits] repo/gentoo:master commit in: net-firewall/ebtables/ Arthur Zamarin
2022-02-04 18:48 Sam James
2021-08-23 11:41 Marek Szuba
2021-05-08 19:11 David Seifert
2021-05-08 18:55 Sam James
2021-05-08 18:49 Sam James
2021-05-08 18:44 Sam James
2021-05-08 18:41 Sam James
2021-02-09 15:59 Mike Frysinger
2021-02-09 15:59 Mike Frysinger
2021-02-09 15:59 Mike Frysinger
2020-12-29 17:02 Mike Gilbert
2020-08-20 13:20 Sam James
2020-07-19 23:31 Sam James
2020-07-18 17:06 Sam James
2020-07-17 15:21 Agostino Sarubbo
2020-06-19  6:51 Lars Wendler
2020-06-19  6:51 Lars Wendler
2020-05-10 20:49 Patrick McLean
2020-05-09  2:55 Patrick McLean
2020-05-04 17:36 Thomas Deutschmann
2019-12-28 21:32 Georgy Yakovlev
2018-03-07 19:26 Mike Gilbert
2018-03-07 19:26 Mike Gilbert
2015-09-29 19:53 Mike Frysinger
2015-09-23  2:33 Mike Frysinger
2015-09-23  2:33 Mike Frysinger
2015-09-23  2:33 Mike Frysinger
2015-09-22 21:39 Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442975584.244fec074ecb3fa9f3a9fc6cb50dab40acef59d1.vapier@gentoo \
    --to=vapier@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox