From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 305821384AE for ; Sat, 19 Sep 2015 16:28:14 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B85D421C073; Sat, 19 Sep 2015 16:28:05 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 52C2921C073 for ; Sat, 19 Sep 2015 16:28:05 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 83D56340F2A for ; Sat, 19 Sep 2015 16:28:04 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 267281FD for ; Sat, 19 Sep 2015 16:28:03 +0000 (UTC) From: "Brian Dolbec" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Brian Dolbec" Message-ID: <1442679983.7c6cbf30221368c5526f8036f0b6d9b7b28210dc.dolsen@gentoo> Subject: [gentoo-commits] proj/portage:repoman commit in: pym/repoman/ X-VCS-Repository: proj/portage X-VCS-Files: pym/repoman/repos.py X-VCS-Directories: pym/repoman/ X-VCS-Committer: dolsen X-VCS-Committer-Name: Brian Dolbec X-VCS-Revision: 7c6cbf30221368c5526f8036f0b6d9b7b28210dc X-VCS-Branch: repoman Date: Sat, 19 Sep 2015 16:28:03 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: 9cdd76c7-6ce7-4094-a4ad-57596c82956c X-Archives-Hash: 1283ac7c3730a65347fdb469fa2232bd commit: 7c6cbf30221368c5526f8036f0b6d9b7b28210dc Author: Brian Dolbec gentoo org> AuthorDate: Sat Sep 19 16:26:23 2015 +0000 Commit: Brian Dolbec gentoo org> CommitDate: Sat Sep 19 16:26:23 2015 +0000 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=7c6cbf30 repoman/repos.py: Detect the lack of a vcs type in vcs_settings to not do a function call pym/repoman/repos.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/pym/repoman/repos.py b/pym/repoman/repos.py index 1a3a0d5..f16bf7a 100644 --- a/pym/repoman/repos.py +++ b/pym/repoman/repos.py @@ -61,8 +61,11 @@ class RepoSettings(object): qawarnings.add("virtual.oldstyle") if self.repo_config.sign_commit: - func = getattr(self, '_vcs_gpg_%s' % vcs_settings.vcs) - func() + if vcs_settings.vcs: + func = getattr(self, '_vcs_gpg_%s' % vcs_settings.vcs) + func() + else: + logging.warning("No VCS type detected, unable to sign the commit") # In order to disable manifest signatures, repos may set # "sign-manifests = false" in metadata/layout.conf. This