public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Brian Dolbec" <dolsen@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/catalyst:2.X commit in: targets/stage1/
Date: Wed,  8 Jul 2015 20:33:01 +0000 (UTC)	[thread overview]
Message-ID: <1436387184.dbdbb28755e61bddcb5b632518df6954a7bb0b00.dolsen@gentoo> (raw)

commit:     dbdbb28755e61bddcb5b632518df6954a7bb0b00
Author:     Brian Dolbec <dolsen <AT> gentoo <DOT> org>
AuthorDate: Wed Jul  8 20:26:24 2015 +0000
Commit:     Brian Dolbec <dolsen <AT> gentoo <DOT> org>
CommitDate: Wed Jul  8 20:26:24 2015 +0000
URL:        https://gitweb.gentoo.org/proj/catalyst.git/commit/?id=dbdbb287

targets/stage1/build.py: Fix bug 554154

portage.dep_getkey(pkgs[idx])

This always throws and exception because of the leading '*' making the purpose
of the entire loop from 28-35 useless.

X-Gentoo-Bug: 554154
X-Gentoo-Bug-Url: https://bugs.gentoo.org/show_bug.cgi?id=554154
X-Gentoo-Reporter: Anthony Basile <bluness <AT> gentoo.org>

Signed-off-by: Brian Dolbec <dolsen <AT> gentoo.org>

 targets/stage1/build.py | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/targets/stage1/build.py b/targets/stage1/build.py
index bf20bcf..8a8a3b1 100755
--- a/targets/stage1/build.py
+++ b/targets/stage1/build.py
@@ -26,11 +26,11 @@ buildpkgs = scan_profile("packages.build")
 # system profile (it may have <,>,=,etc... operators
 # and version numbers)
 for idx in range(0, len(pkgs)):
+	pkg = pkgs[idx].lstrip('*')
 	try:
-		bidx = buildpkgs.index(portage.dep_getkey(pkgs[idx]))
-		buildpkgs[bidx] = pkgs[idx]
-		if buildpkgs[bidx][0:1] == "*":
-			buildpkgs[bidx] = buildpkgs[bidx][1:]
-	except: pass
+		bidx = buildpkgs.index(portage.dep_getkey(pkg))
+		buildpkgs[bidx] = pkg
+	except:
+		pass
 
 for b in buildpkgs: sys.stdout.write(b+" ")


             reply	other threads:[~2015-07-08 20:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-08 20:33 Brian Dolbec [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-06-04 16:50 [gentoo-commits] proj/catalyst:2.X commit in: targets/stage1/ Anthony G. Basile
2015-02-19 20:35 Anthony G. Basile
2014-09-11  2:23 Brian Dolbec
2014-03-24 16:08 Brian Dolbec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436387184.dbdbb28755e61bddcb5b632518df6954a7bb0b00.dolsen@gentoo \
    --to=dolsen@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox