From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 19817138CC4 for ; Wed, 18 Mar 2015 15:32:55 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 7357EE0935; Wed, 18 Mar 2015 15:32:53 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 120EAE0935 for ; Wed, 18 Mar 2015 15:32:53 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 1949C3409CF for ; Wed, 18 Mar 2015 15:32:52 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 7DA7814038 for ; Wed, 18 Mar 2015 15:32:48 +0000 (UTC) From: "Brian Dolbec" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Brian Dolbec" Message-ID: <1426692737.1f8fc87469153591e4cefeb93bdff0ba995c5190.dolsen@gentoo> Subject: [gentoo-commits] proj/gentoo-keys:master commit in: gkeys/gkeys/ X-VCS-Repository: proj/gentoo-keys X-VCS-Files: gkeys/gkeys/checks.py X-VCS-Directories: gkeys/gkeys/ X-VCS-Committer: dolsen X-VCS-Committer-Name: Brian Dolbec X-VCS-Revision: 1f8fc87469153591e4cefeb93bdff0ba995c5190 X-VCS-Branch: master Date: Wed, 18 Mar 2015 15:32:48 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: 457d87bd-e589-4482-b8c2-6b995f18f8a1 X-Archives-Hash: 1371688263f1a33cd2852673df69f533 commit: 1f8fc87469153591e4cefeb93bdff0ba995c5190 Author: Brian Dolbec gentoo org> AuthorDate: Wed Mar 18 15:32:17 2015 +0000 Commit: Brian Dolbec gentoo org> CommitDate: Wed Mar 18 15:32:17 2015 +0000 URL: https://gitweb.gentoo.org/proj/gentoo-keys.git/commit/?id=1f8fc874 gkeys/checks.py: Downgrade the logging to warn from error logging.error also prints to the screen which we don't want in this case. The logging.warn is fine for these errors since they are already shown in a formatted output. gkeys/gkeys/checks.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gkeys/gkeys/checks.py b/gkeys/gkeys/checks.py index a3af3ab..7e40720 100644 --- a/gkeys/gkeys/checks.py +++ b/gkeys/gkeys/checks.py @@ -369,10 +369,10 @@ class KeyChecks(object): stats[SPEC_INDEX['expire']] = True elif days > delta_t and not ('i' in data.validity or 'r' in data.validity): stats[SPEC_INDEX['expire_reason']] = '<== Exceeds specification' - self.logger.error("ERROR in key %s : gpg key expire date: %s EXCEEDS specification" + self.logger.warn("ERROR in key %s : gpg key expire date: %s EXCEEDS specification" % (data.long_keyid, data.expiredate)) else: - self.logger.error("ERROR in key %s : invalid gpg key expire date: %s" + self.logger.warn("ERROR in key %s : invalid gpg key expire date: %s" % (data.long_keyid, data.expiredate)) if 0 < days < 30 and not ('i' in data.validity or 'r' in data.validity): stats[SPEC_INDEX['expire_reason']] = '<== WARNING < 30 days' @@ -398,7 +398,7 @@ class KeyChecks(object): stats[SPEC_INDEX['encrypt_capable']] = True elif cap not in CAPABILITY_MAP: stats[SPEC_INDEX['caps']] = False - self.logger.error("ERROR in key %s : unknown gpg key capability: %s" + self.logger.warn("ERROR in key %s : unknown gpg key capability: %s" % (data.long_keyid, cap)) stats[SPEC_INDEX['long_caps']] = ', '.join(kcaps) return stats