From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 32C19138CBB for ; Tue, 3 Mar 2015 21:28:16 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id BA4B9E0925; Tue, 3 Mar 2015 21:28:14 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 71A99E0925 for ; Tue, 3 Mar 2015 21:28:14 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 0AAEE340A95 for ; Tue, 3 Mar 2015 21:28:13 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id ADBF212F9A for ; Tue, 3 Mar 2015 21:28:11 +0000 (UTC) From: "Zac Medico" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Zac Medico" Message-ID: <1425418038.27eecce94b4e897f13d9f4bae129db37368895c9.zmedico@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: pym/_emerge/ X-VCS-Repository: proj/portage X-VCS-Files: pym/_emerge/depgraph.py X-VCS-Directories: pym/_emerge/ X-VCS-Committer: zmedico X-VCS-Committer-Name: Zac Medico X-VCS-Revision: 27eecce94b4e897f13d9f4bae129db37368895c9 X-VCS-Branch: master Date: Tue, 3 Mar 2015 21:28:11 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: c58c9b3f-5355-42ce-bd1e-978356673ebe X-Archives-Hash: 87cbeda58cb4d3e25639477c250f7aaa commit: 27eecce94b4e897f13d9f4bae129db37368895c9 Author: Zac Medico gentoo org> AuthorDate: Sun Mar 1 03:17:54 2015 +0000 Commit: Zac Medico gentoo org> CommitDate: Tue Mar 3 21:27:18 2015 +0000 URL: http://sources.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=27eecce9 depgraph: fix 'operation' AttributeError (bug 541754) Since commit 4f5e4f697e2593df164fc9864893768f7d2375fc, this faulty code has gone unreported because it's only triggered by invalid dependencies in /var/db/pkg. Fixes: 4f5e4f697e25 ("Use Package instance attributes to clean up and simplify depgraph.validate_blockers().") X-Gentoo-Bug: 541754 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=541754 Acked-by: Brian Dolbec gentoo.org> pym/_emerge/depgraph.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pym/_emerge/depgraph.py b/pym/_emerge/depgraph.py index e8a3110..37292a6 100644 --- a/pym/_emerge/depgraph.py +++ b/pym/_emerge/depgraph.py @@ -6595,7 +6595,7 @@ class depgraph(object): if not success: replacement_pkgs = self._dynamic_config._package_tracker.match( myroot, pkg.slot_atom) - if any(replacement_pkg[0].operation == "merge" for \ + if any(replacement_pkg.operation == "merge" for replacement_pkg in replacement_pkgs): # This package is being replaced anyway, so # ignore invalid dependencies so as not to