From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 31541138A1C for ; Fri, 31 Oct 2014 15:32:50 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 2CF21E0857; Fri, 31 Oct 2014 15:32:49 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 5C5DDE0857 for ; Fri, 31 Oct 2014 15:32:48 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 49BAB34050B for ; Fri, 31 Oct 2014 15:32:47 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id EAAEF9263 for ; Fri, 31 Oct 2014 15:32:45 +0000 (UTC) From: "Sven Vermeulen" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Sven Vermeulen" Message-ID: <1414769187.25635ce6697a48861fa0f3021f79261f760b4d99.swift@gentoo> Subject: [gentoo-commits] proj/hardened-refpolicy:master commit in: policy/modules/system/ X-VCS-Repository: proj/hardened-refpolicy X-VCS-Files: policy/modules/system/ipsec.te policy/modules/system/sysnetwork.te X-VCS-Directories: policy/modules/system/ X-VCS-Committer: swift X-VCS-Committer-Name: Sven Vermeulen X-VCS-Revision: 25635ce6697a48861fa0f3021f79261f760b4d99 X-VCS-Branch: master Date: Fri, 31 Oct 2014 15:32:45 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: a6c51e2d-8c0e-4156-81e2-16182541c33c X-Archives-Hash: a2ac91f8e3722622a6b2cb15c78e0a51 commit: 25635ce6697a48861fa0f3021f79261f760b4d99 Author: Nicolas Iooss m4x org> AuthorDate: Sat Oct 18 13:30:22 2014 +0000 Commit: Sven Vermeulen gentoo org> CommitDate: Fri Oct 31 15:26:27 2014 +0000 URL: http://sources.gentoo.org/gitweb/?p=proj/hardened-refpolicy.git;a=commit;h=25635ce6 Use create_netlink_socket_perms when allowing netlink socket creation create_netlink_socket_perms is defined as: { create_socket_perms nlmsg_read nlmsg_write } This means that it is redundant to allow create_socket_perms and nlmsg_read/nlmsg_write. Clean up things without allowing anything new. --- policy/modules/system/ipsec.te | 2 +- policy/modules/system/sysnetwork.te | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/policy/modules/system/ipsec.te b/policy/modules/system/ipsec.te index db6d1c6..15d7caf 100644 --- a/policy/modules/system/ipsec.te +++ b/policy/modules/system/ipsec.te @@ -79,7 +79,7 @@ allow ipsec_t self:tcp_socket create_stream_socket_perms; allow ipsec_t self:udp_socket create_socket_perms; allow ipsec_t self:key_socket create_socket_perms; allow ipsec_t self:fifo_file read_fifo_file_perms; -allow ipsec_t self:netlink_xfrm_socket { create_netlink_socket_perms nlmsg_write }; +allow ipsec_t self:netlink_xfrm_socket create_netlink_socket_perms; allow ipsec_t ipsec_initrc_exec_t:file read_file_perms; diff --git a/policy/modules/system/sysnetwork.te b/policy/modules/system/sysnetwork.te index b95de37..f7dbde0 100644 --- a/policy/modules/system/sysnetwork.te +++ b/policy/modules/system/sysnetwork.te @@ -57,7 +57,7 @@ allow dhcpc_t self:fifo_file rw_fifo_file_perms; allow dhcpc_t self:tcp_socket create_stream_socket_perms; allow dhcpc_t self:udp_socket create_socket_perms; allow dhcpc_t self:packet_socket create_socket_perms; -allow dhcpc_t self:netlink_route_socket { create_socket_perms nlmsg_read nlmsg_write }; +allow dhcpc_t self:netlink_route_socket create_netlink_socket_perms; allow dhcpc_t dhcp_etc_t:dir list_dir_perms; read_lnk_files_pattern(dhcpc_t, dhcp_etc_t, dhcp_etc_t) @@ -278,7 +278,7 @@ allow ifconfig_t self:udp_socket create_socket_perms; allow ifconfig_t self:packet_socket create_socket_perms; allow ifconfig_t self:netlink_socket create_socket_perms; allow ifconfig_t self:netlink_route_socket create_netlink_socket_perms; -allow ifconfig_t self:netlink_xfrm_socket { create_netlink_socket_perms nlmsg_read }; +allow ifconfig_t self:netlink_xfrm_socket create_netlink_socket_perms; allow ifconfig_t self:tcp_socket { create ioctl }; kernel_use_fds(ifconfig_t)