public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Richard Farina" <zerochaos@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/qa-scripts:master commit in: tinderbox/
Date: Thu, 28 Aug 2014 18:30:52 +0000 (UTC)	[thread overview]
Message-ID: <1409250636.08cf4285e90a4521340ba1714ee0c0f80176de71.zerochaos@gentoo> (raw)

commit:     08cf4285e90a4521340ba1714ee0c0f80176de71
Author:     Rick Farina (Zero_Chaos) <zerochaos <AT> gentoo <DOT> org>
AuthorDate: Thu Aug 28 18:30:36 2014 +0000
Commit:     Richard Farina <zerochaos <AT> gentoo <DOT> org>
CommitDate: Thu Aug 28 18:30:36 2014 +0000
URL:        http://sources.gentoo.org/gitweb/?p=proj/qa-scripts.git;a=commit;h=08cf4285

proper fix for empty logging dir

revert 6f206114aa3b978fc7206cd2d329114db461ea55, proper fix is to just
use recursive grep.

---
 tinderbox/bashrc | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/tinderbox/bashrc b/tinderbox/bashrc
index 6d21868..b378dac 100644
--- a/tinderbox/bashrc
+++ b/tinderbox/bashrc
@@ -108,11 +108,9 @@ tinderbox_postinst_checks() {
 
 	SANDBOX_ON=0 cp "${T}"/testsfailed "${BUILD_DATA_DIR}" 2> /dev/null
 	SANDBOX_ON=0 find "${T}" -name "tinderbox-*.log" -not -empty -execdir mv '{}' "${BUILD_DATA_DIR}" \;
-	if [ ls "${T}"/logging/* > /dev/null 2>&1 ] ; then
-		SANDBOX_ON=0 grep --no-filename QA "${T}"/logging/* > "${BUILD_DATA_DIR}"/portageqa
-	fi
+	SANDBOX_ON=0 grep --no-filename -r QA "${T}"/logging/ > "${BUILD_DATA_DIR}"/portageqa
 
-	if [[ ! -s "${BUILD_DATA_DIR}"/portageqa ]] && [ -f "${BUILD_DATA_DIR}"/portageqa ] ; then
+	if [[ ! -s "${BUILD_DATA_DIR}"/portageqa ]] ; then
 		SANDBOX_ON=0 rm "${BUILD_DATA_DIR}"/portageqa
 	fi
 


             reply	other threads:[~2014-08-28 18:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-28 18:30 Richard Farina [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-08-28 18:12 [gentoo-commits] proj/qa-scripts:master commit in: tinderbox/ Richard Farina
2014-08-28  4:51 Michael Palimaka
2014-08-28  4:19 Richard Farina
2014-08-28  4:19 Richard Farina
2014-06-08 17:59 Michael Palimaka
2014-06-08 16:30 Michael Palimaka
2014-06-04 14:55 Michael Palimaka
2014-06-04 14:55 Michael Palimaka
2014-06-04 14:55 Michael Palimaka
2014-06-04 14:55 Michael Palimaka
2014-05-29 19:39 Michael Palimaka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409250636.08cf4285e90a4521340ba1714ee0c0f80176de71.zerochaos@gentoo \
    --to=zerochaos@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox