public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "William Hubbs" <williamh@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/openrc:master commit in: init.d/, conf.d/
Date: Fri, 22 Aug 2014 19:10:09 +0000 (UTC)	[thread overview]
Message-ID: <1407527340.6a337ff6c531d9d7310253b67b3e95d1ce5d214c.williamh@OpenRC> (raw)

commit:     6a337ff6c531d9d7310253b67b3e95d1ce5d214c
Author:     William Hubbs <w.d.hubbs <AT> gmail <DOT> com>
AuthorDate: Fri Aug  8 19:49:00 2014 +0000
Commit:     William Hubbs <williamh <AT> gentoo <DOT> org>
CommitDate: Fri Aug  8 19:49:00 2014 +0000
URL:        http://sources.gentoo.org/gitweb/?p=proj/openrc.git;a=commit;h=6a337ff6

devfs: several small clarifications

- Rename the static_dev switch in conf.d/devfs to skip_mount_dev since
  this is a better description of what the switch does.

- Clarify the error messages in the devfs service script based on the
  new name of the switch.

---
 conf.d/devfs    | 10 ++++++++--
 init.d/devfs.in | 14 ++++++++------
 2 files changed, 16 insertions(+), 8 deletions(-)

diff --git a/conf.d/devfs b/conf.d/devfs
index 92a8a99..51f8037 100644
--- a/conf.d/devfs
+++ b/conf.d/devfs
@@ -1,2 +1,8 @@
-# Set this to yes if your /dev is not a devtmpfs or tmpfs.
-# static_dev="NO"
+# OpenRC will attempt each of the following in succession to mount /dev.
+#
+# 1. If there is an entry for /dev in fstab, it will be used.
+# 2. If devtmpfs is defined in the kernel, it will be used.
+# 3. If tmpfs is defined in the kernel, it will be used.
+#
+# Set this to yes if you do not want OpenRC to attempt to mount /dev.
+# skip_mount_dev="NO"

diff --git a/init.d/devfs.in b/init.d/devfs.in
index ca24231..bcdbdcd 100644
--- a/init.d/devfs.in
+++ b/init.d/devfs.in
@@ -16,8 +16,8 @@ mount_dev()
 	local action=--mount devfstype msg=Mounting
 	# Some devices require exec, Bug #92921
 	local mountopts="exec,nosuid,mode=0755"
-	if yesno ${static_dev:-no}; then
-		einfo "Using static /dev"
+	if yesno ${skip_mount_dev:-no} ; then
+		einfo "/dev will not be mounted due to user request"
 		return 0
 	fi
 	if mountinfo -q /dev; then
@@ -43,11 +43,13 @@ mount_dev()
 		mount -n -t $devfstype -o $mountopts dev /dev
 		eend $?
 	else
-		ewarn "This kernel does not have devtmpfs or tmpfs support."
-		ewarn "Assuming you want static /dev. If this is not the case,"
-		ewarn "please set the CONFIG_DEVTMPFS or CONFIG_TMPFS option"
-		ewarn "in your kernel."
+		ewarn "This kernel does not have devtmpfs or tmpfs support, and there"
+		ewarn "is no entry for /dev in fstab."
+		ewarn "This means /dev will not be mounted."
+		ewarn "To avoid this message, set CONFIG_DEVTMPFS or CONFIG_TMPFS to y"
+		ewarn "in your kernel configuration or see @SYSCONFDIR@/conf.d/devfs"
 	fi
+	return 0
 }
 
 seed_dev()


WARNING: multiple messages have this Message-ID (diff)
From: "William Hubbs" <williamh@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/openrc:master commit in: init.d/, conf.d/
Date: Fri,  8 Aug 2014 23:19:11 +0000 (UTC)	[thread overview]
Message-ID: <1407527340.6a337ff6c531d9d7310253b67b3e95d1ce5d214c.williamh@OpenRC> (raw)
Message-ID: <20140808231911.WUs5TOqY2iBstNxODtZIHlBp_AyGXznwtWOOzuneznE@z> (raw)

commit:     6a337ff6c531d9d7310253b67b3e95d1ce5d214c
Author:     William Hubbs <w.d.hubbs <AT> gmail <DOT> com>
AuthorDate: Fri Aug  8 19:49:00 2014 +0000
Commit:     William Hubbs <williamh <AT> gentoo <DOT> org>
CommitDate: Fri Aug  8 19:49:00 2014 +0000
URL:        http://git.overlays.gentoo.org/gitweb/?p=proj/openrc.git;a=commit;h=6a337ff6

devfs: several small clarifications

- Rename the static_dev switch in conf.d/devfs to skip_mount_dev since
  this is a better description of what the switch does.

- Clarify the error messages in the devfs service script based on the
  new name of the switch.

---
 conf.d/devfs    | 10 ++++++++--
 init.d/devfs.in | 14 ++++++++------
 2 files changed, 16 insertions(+), 8 deletions(-)

diff --git a/conf.d/devfs b/conf.d/devfs
index 92a8a99..51f8037 100644
--- a/conf.d/devfs
+++ b/conf.d/devfs
@@ -1,2 +1,8 @@
-# Set this to yes if your /dev is not a devtmpfs or tmpfs.
-# static_dev="NO"
+# OpenRC will attempt each of the following in succession to mount /dev.
+#
+# 1. If there is an entry for /dev in fstab, it will be used.
+# 2. If devtmpfs is defined in the kernel, it will be used.
+# 3. If tmpfs is defined in the kernel, it will be used.
+#
+# Set this to yes if you do not want OpenRC to attempt to mount /dev.
+# skip_mount_dev="NO"

diff --git a/init.d/devfs.in b/init.d/devfs.in
index ca24231..bcdbdcd 100644
--- a/init.d/devfs.in
+++ b/init.d/devfs.in
@@ -16,8 +16,8 @@ mount_dev()
 	local action=--mount devfstype msg=Mounting
 	# Some devices require exec, Bug #92921
 	local mountopts="exec,nosuid,mode=0755"
-	if yesno ${static_dev:-no}; then
-		einfo "Using static /dev"
+	if yesno ${skip_mount_dev:-no} ; then
+		einfo "/dev will not be mounted due to user request"
 		return 0
 	fi
 	if mountinfo -q /dev; then
@@ -43,11 +43,13 @@ mount_dev()
 		mount -n -t $devfstype -o $mountopts dev /dev
 		eend $?
 	else
-		ewarn "This kernel does not have devtmpfs or tmpfs support."
-		ewarn "Assuming you want static /dev. If this is not the case,"
-		ewarn "please set the CONFIG_DEVTMPFS or CONFIG_TMPFS option"
-		ewarn "in your kernel."
+		ewarn "This kernel does not have devtmpfs or tmpfs support, and there"
+		ewarn "is no entry for /dev in fstab."
+		ewarn "This means /dev will not be mounted."
+		ewarn "To avoid this message, set CONFIG_DEVTMPFS or CONFIG_TMPFS to y"
+		ewarn "in your kernel configuration or see @SYSCONFDIR@/conf.d/devfs"
 	fi
+	return 0
 }
 
 seed_dev()


             reply	other threads:[~2014-08-22 19:10 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-22 19:10 William Hubbs [this message]
2014-08-08 23:19 ` [gentoo-commits] proj/openrc:master commit in: init.d/, conf.d/ William Hubbs
  -- strict thread matches above, loose matches on Subject: below --
2017-10-06 19:44 William Hubbs
2017-05-22 17:54 William Hubbs
2016-04-25 17:12 William Hubbs
2016-01-19 19:37 William Hubbs
2016-01-13 17:02 William Hubbs
2014-01-05 21:59 William Hubbs
2012-10-26  0:58 William Hubbs
2012-02-18 19:11 William Hubbs
2012-02-18 19:11 William Hubbs
2011-11-26 18:22 Mike Frysinger
2011-11-23  0:55 William Hubbs
2011-11-07  4:07 William Hubbs
2011-11-06 20:04 William Hubbs
2011-09-27 16:16 Christian Ruppert
2011-07-04  7:52 Robin H. Johnson
2011-06-24  2:58 William Hubbs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1407527340.6a337ff6c531d9d7310253b67b3e95d1ce5d214c.williamh@OpenRC \
    --to=williamh@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox