From: "Michael Palimaka" <kensington@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/qa-scripts:master commit in: tinderbox/
Date: Wed, 4 Jun 2014 14:55:57 +0000 (UTC) [thread overview]
Message-ID: <1401893303.0e6e3a57a8de9287892f2a67cd37632b43754aee.kensington@gentoo> (raw)
commit: 0e6e3a57a8de9287892f2a67cd37632b43754aee
Author: Michael Palimaka <kensington <AT> gentoo <DOT> org>
AuthorDate: Wed Jun 4 14:06:06 2014 +0000
Commit: Michael Palimaka <kensington <AT> gentoo <DOT> org>
CommitDate: Wed Jun 4 14:48:23 2014 +0000
URL: http://git.overlays.gentoo.org/gitweb/?p=proj/qa-scripts.git;a=commit;h=0e6e3a57
tinderbox: return the exit status of the make function override.
This ensure that tests are correctly detected as passed/failed by
portage.
Also, calling /usr/bin/make instead of emake should more
accurately replicate the behaviour intended by the original
function call.
---
tinderbox/bashrc | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/tinderbox/bashrc b/tinderbox/bashrc
index 763979c..47bb19e 100644
--- a/tinderbox/bashrc
+++ b/tinderbox/bashrc
@@ -140,17 +140,16 @@ tinderbox_log() {
#
make() {
- if [[ "${FUNCNAME[1]}" == "einstall" ]] ; then
- emake -j1 "$@"
+ if [[ "${FUNCNAME[1]}" == "einstall" || "${FUNCNAME[1]}" == "__eapi0_src_test" ]] ; then
+ /usr/bin/make -j1 "$@"
+ ret=$?
else
emake "$@"
-
- if [[ "${FUNCNAME[1]}" == "__eapi0_src_test" ]] ; then
- return
- fi
-
+ ret=$?
eqawarn QA Notice: direct 'make' call by ${FUNCNAME[1]}
fi
+
+ return ${ret}
}
#
next reply other threads:[~2014-06-04 14:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 14:55 Michael Palimaka [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-08-28 18:30 [gentoo-commits] proj/qa-scripts:master commit in: tinderbox/ Richard Farina
2014-08-28 18:12 Richard Farina
2014-08-28 4:51 Michael Palimaka
2014-08-28 4:19 Richard Farina
2014-08-28 4:19 Richard Farina
2014-06-08 17:59 Michael Palimaka
2014-06-08 16:30 Michael Palimaka
2014-06-04 14:55 Michael Palimaka
2014-06-04 14:55 Michael Palimaka
2014-06-04 14:55 Michael Palimaka
2014-05-29 19:39 Michael Palimaka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401893303.0e6e3a57a8de9287892f2a67cd37632b43754aee.kensington@gentoo \
--to=kensington@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox