From: "Brian Dolbec" <brian.dolbec@gmail.com> To: gentoo-commits@lists.gentoo.org Subject: [gentoo-commits] proj/catalyst:pending commit in: / Date: Sat, 22 Feb 2014 21:48:38 +0000 (UTC) [thread overview] Message-ID: <1393105398.f35597df0a9fe361e8d95fb8d1e53b887c95c96f.dol-sen@gentoo> (raw) commit: f35597df0a9fe361e8d95fb8d1e53b887c95c96f Author: W. Trevor King <wking <AT> tremily <DOT> us> AuthorDate: Sat Feb 22 19:37:36 2014 +0000 Commit: Brian Dolbec <brian.dolbec <AT> gmail <DOT> com> CommitDate: Sat Feb 22 21:43:18 2014 +0000 URL: http://git.overlays.gentoo.org/gitweb/?p=proj/catalyst.git;a=commit;h=f35597df Makefile: Fix PACKAGE_VERSION extraction The old method grepped for __version__ in catalyst. That broke with 24c5352 (Initial rearrangement of the python directories, 2013-01-10), which moved catalyst to bin/catalyst, kept the __version__ in bin/catalyst, and added a new __version__ in catalyst/main.py. Then 46b261e (setup.py: Add disutils-based packaging, 2013-06-05) consolidated the __version__ definitions in catalyst/__init__.py, removing them from bin/catalyst and catalyst/main.py. This patch adjusts the Makefile, invoking Python to extract catalyst.__version__ instead of grepping through the file that defines it. --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 98accbe..757113c 100644 --- a/Makefile +++ b/Makefile @@ -1,7 +1,7 @@ # Copyright (C) 2011 Sebastian Pipping <sebastian@pipping.org> # Licensed under GPL v2 or later -PACKAGE_VERSION = `fgrep '__version__=' catalyst | sed 's|^__version__="\(.*\)"$$|\1|'` +PACKAGE_VERSION = $(shell PYTHONPATH=. python -c 'import catalyst; print(catalyst.__version__)') MAN_PAGE_SOURCES = $(wildcard doc/*.?.txt) MAN_PAGES = $(patsubst doc/%.txt,files/%,$(MAN_PAGE_SOURCES)) MAN_PAGE_INCLUDES = doc/subarches.generated.txt doc/targets.generated.txt
WARNING: multiple messages have this Message-ID (diff)
From: "Brian Dolbec" <brian.dolbec@gmail.com> To: gentoo-commits@lists.gentoo.org Subject: [gentoo-commits] proj/catalyst:master commit in: / Date: Sun, 2 Mar 2014 15:42:16 +0000 (UTC) [thread overview] Message-ID: <1393105398.f35597df0a9fe361e8d95fb8d1e53b887c95c96f.dol-sen@gentoo> (raw) Message-ID: <20140302154216.GEg5ET1_trtNVFst9kQYeaQUYC_Tklj6A3FzB9tPCGM@z> (raw) commit: f35597df0a9fe361e8d95fb8d1e53b887c95c96f Author: W. Trevor King <wking <AT> tremily <DOT> us> AuthorDate: Sat Feb 22 19:37:36 2014 +0000 Commit: Brian Dolbec <brian.dolbec <AT> gmail <DOT> com> CommitDate: Sat Feb 22 21:43:18 2014 +0000 URL: http://git.overlays.gentoo.org/gitweb/?p=proj/catalyst.git;a=commit;h=f35597df Makefile: Fix PACKAGE_VERSION extraction The old method grepped for __version__ in catalyst. That broke with 24c5352 (Initial rearrangement of the python directories, 2013-01-10), which moved catalyst to bin/catalyst, kept the __version__ in bin/catalyst, and added a new __version__ in catalyst/main.py. Then 46b261e (setup.py: Add disutils-based packaging, 2013-06-05) consolidated the __version__ definitions in catalyst/__init__.py, removing them from bin/catalyst and catalyst/main.py. This patch adjusts the Makefile, invoking Python to extract catalyst.__version__ instead of grepping through the file that defines it. --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 98accbe..757113c 100644 --- a/Makefile +++ b/Makefile @@ -1,7 +1,7 @@ # Copyright (C) 2011 Sebastian Pipping <sebastian@pipping.org> # Licensed under GPL v2 or later -PACKAGE_VERSION = `fgrep '__version__=' catalyst | sed 's|^__version__="\(.*\)"$$|\1|'` +PACKAGE_VERSION = $(shell PYTHONPATH=. python -c 'import catalyst; print(catalyst.__version__)') MAN_PAGE_SOURCES = $(wildcard doc/*.?.txt) MAN_PAGES = $(patsubst doc/%.txt,files/%,$(MAN_PAGE_SOURCES)) MAN_PAGE_INCLUDES = doc/subarches.generated.txt doc/targets.generated.txt
next reply other threads:[~2014-02-22 21:48 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-02-22 21:48 Brian Dolbec [this message] 2014-03-02 15:42 ` [gentoo-commits] proj/catalyst:master commit in: / Brian Dolbec -- strict thread matches above, loose matches on Subject: below -- 2017-11-22 15:52 [gentoo-commits] proj/catalyst:pending " Brian Dolbec 2017-03-09 9:39 Brian Dolbec 2015-10-06 19:54 Brian Dolbec 2015-09-06 21:21 [gentoo-commits] proj/catalyst:master " Brian Dolbec 2015-09-06 21:18 ` [gentoo-commits] proj/catalyst:pending " Brian Dolbec 2015-09-03 15:14 Brian Dolbec 2015-09-01 5:58 Brian Dolbec 2015-06-15 20:25 Brian Dolbec 2015-06-15 20:25 Brian Dolbec 2015-02-26 22:18 [gentoo-commits] proj/catalyst:master " Brian Dolbec 2015-02-26 20:44 ` [gentoo-commits] proj/catalyst:pending " Brian Dolbec 2015-02-26 22:18 [gentoo-commits] proj/catalyst:master " Brian Dolbec 2015-02-26 20:44 ` [gentoo-commits] proj/catalyst:pending " Brian Dolbec 2015-02-26 22:18 [gentoo-commits] proj/catalyst:master " Brian Dolbec 2015-02-26 20:44 ` [gentoo-commits] proj/catalyst:pending " Brian Dolbec 2015-02-26 20:44 Brian Dolbec 2015-02-26 19:25 Brian Dolbec 2014-03-02 16:07 Brian Dolbec 2014-02-22 21:48 Brian Dolbec 2014-02-22 18:43 Brian Dolbec 2014-02-22 18:43 Brian Dolbec 2014-01-22 15:52 Brian Dolbec 2014-01-03 6:41 Brian Dolbec 2014-01-03 6:12 Brian Dolbec 2014-01-03 5:03 Brian Dolbec 2014-01-03 5:03 Brian Dolbec 2014-01-02 0:04 Brian Dolbec 2013-12-31 18:14 Brian Dolbec 2013-12-31 4:48 Brian Dolbec 2013-12-31 4:39 Brian Dolbec 2013-12-31 4:39 Brian Dolbec 2013-12-31 4:22 Brian Dolbec 2013-12-31 4:22 Brian Dolbec 2013-12-30 1:44 Brian Dolbec 2013-12-30 1:44 Brian Dolbec
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1393105398.f35597df0a9fe361e8d95fb8d1e53b887c95c96f.dol-sen@gentoo \ --to=brian.dolbec@gmail.com \ --cc=gentoo-commits@lists.gentoo.org \ --cc=gentoo-dev@lists.gentoo.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox