[gentoo-commits] proj/portage:plugin-sync commit in: pym/_emerge/

["Brian Dolbec" <brian.dolbec@gmail.com>]

commit:     eff4e326f6feaad6bd1b807bc24eac771419e4ac
Author:     Brian Dolbec <dolsen <AT> gentoo <DOT> org>
AuthorDate: Wed Jan 29 04:05:30 2014 +0000
Commit:     Brian Dolbec <brian.dolbec <AT> gmail <DOT> com>
CommitDate: Wed Jan 29 04:05:30 2014 +0000
URL:        http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=eff4e326

Move the SyncManager initialization out of the loop

Make the returncode not bail out of syncing the remaining repos.

---
 pym/_emerge/actions.py | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/pym/_emerge/actions.py b/pym/_emerge/actions.py
index 6306f4d..6f4de04 100644
--- a/pym/_emerge/actions.py
+++ b/pym/_emerge/actions.py
@@ -1875,13 +1875,13 @@ def action_sync(emerge_config, trees=DeprecationWarning,
 	else:
 		selected_repos.extend(emerge_config.target_config.settings.repositories)
 
+	sync_manager = SyncManager(emerge_config.target_config.settings, emergelog)
+	retvals = []
 	for repo in selected_repos:
 		if repo.sync_type is not None:
-			sync_manager = SyncManager(emerge_config.target_config.settings,
-				emergelog)
 			returncode = sync_manager.sync(emerge_config, repo)
 			if returncode != os.EX_OK:
-				return returncode
+				retvals.append(returncode)
 
 	# Reload the whole config from scratch.
 	portage._sync_mode = False
@@ -1916,6 +1916,8 @@ def action_sync(emerge_config, trees=DeprecationWarning,
 		print()
 
 	display_news_notification(emerge_config.target_config, emerge_config.opts)
+	if retvals:
+		return retvals[0]
 	return os.EX_OK