public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Devan Franchini" <twitch153@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/webapp-config:experimental commit in: WebappConfig/
Date: Fri, 24 Jan 2014 21:45:26 +0000 (UTC)	[thread overview]
Message-ID: <1390599482.ff4cdefb600c0ceb834019bbcd0e1147ea744d6b.twitch153@gentoo> (raw)

commit:     ff4cdefb600c0ceb834019bbcd0e1147ea744d6b
Author:     Devan Franchini <twitch153 <AT> gentoo <DOT> org>
AuthorDate: Fri Jan 24 21:38:02 2014 +0000
Commit:     Devan Franchini <twitch153 <AT> gentoo <DOT> org>
CommitDate: Fri Jan 24 21:38:02 2014 +0000
URL:        http://git.overlays.gentoo.org/gitweb/?p=proj/webapp-config.git;a=commit;h=ff4cdefb

WebappConfig/db.py: Properly closes install file after writing.

When webapp-config cleans out a webapp installation it needs to
remove the database entry of the file from it's designated installs
file. If more than one database entry is in the installs file it
should still list the database entry for the webapp that isn't being
removed. The logic is all there in db.py but after the file has
rewritten the entries it doesn't close the file properly and causes
a failure in the check right after the write(), which then unlinks
the installs file and removes the entries from webapp-config's
database.

X-Gentoo-Bug:494520
X-Gentoo-Bug-URL: https://bugs.gentoo.org/494520

---
 WebappConfig/db.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/WebappConfig/db.py b/WebappConfig/db.py
index 228b2c8..2d70cb9 100644
--- a/WebappConfig/db.py
+++ b/WebappConfig/db.py
@@ -340,6 +340,7 @@ class WebappDB(AppHierarchy):
         if not self.__p:
             installs = open(dbpath, 'w')
             installs.write('\n'.join(newentries) + '\n')
+            installs.close()
             if not self.has_installs():
                 os.unlink(dbpath)
         else:


             reply	other threads:[~2014-01-24 21:45 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-24 21:45 Devan Franchini [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-06-19 19:19 [gentoo-commits] proj/webapp-config:experimental commit in: WebappConfig/ Devan Franchini
2015-06-19 19:19 Devan Franchini
2015-06-19 19:19 Devan Franchini
2015-06-19 19:19 Devan Franchini
2015-06-19 19:19 Devan Franchini
2015-06-19 19:19 Devan Franchini
2015-06-19 19:19 Devan Franchini
2015-06-19 19:19 Devan Franchini
2015-06-19 19:19 Devan Franchini
2015-06-19 19:19 Devan Franchini
2015-06-19 19:19 Devan Franchini
2015-06-19 19:19 Devan Franchini
2015-06-19 19:19 Devan Franchini
2015-05-17  3:54 Devan Franchini
2015-05-17  3:44 Devan Franchini
2015-05-17  3:19 Devan Franchini
2015-05-17  2:51 Devan Franchini
2015-05-17  2:42 Devan Franchini
2015-05-17  2:28 Devan Franchini
2015-05-17  0:38 Devan Franchini
2015-05-16  2:16 Devan Franchini
2014-11-18  0:03 Devan Franchini
2014-11-17 23:58 Devan Franchini
2014-11-17 23:42 Devan Franchini
2014-11-14  1:14 Devan Franchini
2014-10-16 19:18 Devan Franchini
2014-10-15 13:27 Devan Franchini
2014-10-15 13:27 Devan Franchini
2014-10-15 13:27 Devan Franchini
2014-10-14 19:13 Devan Franchini
2014-10-14 17:14 Devan Franchini
2014-10-09 18:02 Devan Franchini
2014-10-09 17:58 Devan Franchini
2014-10-09 17:52 Devan Franchini
2014-09-23 17:09 Devan Franchini
2014-04-26 19:33 Devan Franchini
2014-01-22 15:32 Devan Franchini
2014-01-08  4:03 Devan Franchini
2014-01-04  1:40 Devan Franchini
2014-01-04  1:13 Devan Franchini
2013-12-19  6:34 Devan Franchini
2013-12-10  1:34 Devan Franchini
2013-12-09  8:31 Devan Franchini
2013-12-01  8:50 Devan Franchini
2013-12-01  8:44 Devan Franchini
2013-11-05 22:17 Devan Franchini
2013-11-05 22:17 Devan Franchini
2013-10-29  2:18 Devan Franchini
2013-10-27 19:27 Devan Franchini
2013-10-27  2:26 Devan Franchini
2013-10-19  3:34 Devan Franchini
2013-10-18  3:39 Devan Franchini
2013-10-10  3:46 Devan Franchini
2013-10-10  3:41 Devan Franchini
2013-10-10  3:36 Devan Franchini
2013-10-10  2:00 Devan Franchini
2013-09-23  3:51 Devan Franchini
2013-09-23  1:13 Devan Franchini
2013-09-23  1:06 Devan Franchini
2013-09-23  0:19 Devan Franchini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1390599482.ff4cdefb600c0ceb834019bbcd0e1147ea744d6b.twitch153@gentoo \
    --to=twitch153@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox