From: "Brian Dolbec" <brian.dolbec@gmail.com>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/catalyst:pending commit in: modules/
Date: Fri, 3 Jan 2014 05:03:22 +0000 (UTC) [thread overview]
Message-ID: <1388723968.c0c0a87d2a22a73e9b8a2e754bed5b185ed54aec.dol-sen@gentoo> (raw)
commit: c0c0a87d2a22a73e9b8a2e754bed5b185ed54aec
Author: Brian Dolbec <dolsen <AT> gentoo <DOT> org>
AuthorDate: Tue Dec 17 06:22:41 2013 +0000
Commit: Brian Dolbec <brian.dolbec <AT> gmail <DOT> com>
CommitDate: Fri Jan 3 04:39:28 2014 +0000
URL: http://git.overlays.gentoo.org/gitweb/?p=proj/catalyst.git;a=commit;h=c0c0a87d
Remove some troublesome trailing slashes from paths
Change the docstring to warn to use a proper path join function.
---
modules/generic_stage_target.py | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/modules/generic_stage_target.py b/modules/generic_stage_target.py
index 7919f07..587b903 100644
--- a/modules/generic_stage_target.py
+++ b/modules/generic_stage_target.py
@@ -460,18 +460,18 @@ class generic_stage_target(generic_target):
if "SNAPCACHE" in self.settings:
self.settings["snapshot_cache_path"]=\
normpath(self.settings["snapshot_cache"]+"/"+\
- self.settings["snapshot"]+"/")
+ self.settings["snapshot"])
self.snapcache_lock=\
catalyst_lock.LockDir(self.settings["snapshot_cache_path"])
print "Caching snapshot to "+self.settings["snapshot_cache_path"]
def set_chroot_path(self):
"""
- NOTE: the trailing slash is very important!
- Things *will* break without it!
+ NOTE: the trailing slash has been removed
+ Things *could* break if you don't use a proper join()
"""
self.settings["chroot_path"]=normpath(self.settings["storedir"]+\
- "/tmp/"+self.settings["target_subpath"]+"/")
+ "/tmp/"+self.settings["target_subpath"])
self.chroot_lock=catalyst_lock.LockDir(self.settings["chroot_path"])
def set_autoresume_path(self):
next reply other threads:[~2014-01-03 5:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-03 5:03 Brian Dolbec [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-01-06 2:00 [gentoo-commits] proj/catalyst:master commit in: modules/ Brian Dolbec
2014-01-03 6:41 ` [gentoo-commits] proj/catalyst:pending " Brian Dolbec
2014-01-06 2:00 [gentoo-commits] proj/catalyst:master " Brian Dolbec
2014-01-03 5:03 ` [gentoo-commits] proj/catalyst:pending " Brian Dolbec
2014-01-06 2:00 [gentoo-commits] proj/catalyst:master " Brian Dolbec
2013-12-31 4:22 ` [gentoo-commits] proj/catalyst:pending " Brian Dolbec
2014-01-06 2:00 [gentoo-commits] proj/catalyst:master " Brian Dolbec
2014-01-03 5:03 ` [gentoo-commits] proj/catalyst:pending " Brian Dolbec
2014-01-03 6:41 Brian Dolbec
2014-01-03 6:12 Brian Dolbec
2014-01-03 6:12 Brian Dolbec
2014-01-03 6:12 Brian Dolbec
2014-01-03 5:03 Brian Dolbec
2014-01-02 0:04 Brian Dolbec
2013-12-31 18:14 Brian Dolbec
2013-12-31 4:48 Brian Dolbec
2013-12-31 4:48 Brian Dolbec
2013-12-31 4:39 Brian Dolbec
2013-12-31 4:39 Brian Dolbec
2013-12-31 4:39 Brian Dolbec
2013-12-31 4:39 Brian Dolbec
2013-12-31 4:22 Brian Dolbec
2013-12-31 4:22 Brian Dolbec
2013-12-31 4:22 Brian Dolbec
2013-12-31 4:22 Brian Dolbec
2013-12-30 1:44 Brian Dolbec
2013-12-30 1:44 Brian Dolbec
2013-12-30 1:44 Brian Dolbec
2013-12-30 1:44 Brian Dolbec
2013-12-30 1:44 Brian Dolbec
2013-12-20 0:48 Brian Dolbec
2013-12-20 0:29 Brian Dolbec
2013-12-20 0:29 Brian Dolbec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1388723968.c0c0a87d2a22a73e9b8a2e754bed5b185ed54aec.dol-sen@gentoo \
--to=brian.dolbec@gmail.com \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox