From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 30B411387B1 for ; Sat, 28 Dec 2013 13:15:49 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 63C59E0A9D; Sat, 28 Dec 2013 13:15:47 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id BAB15E0A9D for ; Sat, 28 Dec 2013 13:15:46 +0000 (UTC) Received: from hornbill.gentoo.org (hornbill.gentoo.org [94.100.119.163]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id D851B33F726 for ; Sat, 28 Dec 2013 13:15:45 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by hornbill.gentoo.org (Postfix) with ESMTP id 5C6F9E5538 for ; Sat, 28 Dec 2013 13:15:43 +0000 (UTC) From: "Ralph Sennhauser" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Ralph Sennhauser" Message-ID: <1388233680.a98d389c9bbc5f691938780c22557533fb885e8b.sera@gentoo> Subject: [gentoo-commits] proj/java-config:master commit in: src/java_config_2/ X-VCS-Repository: proj/java-config X-VCS-Files: src/java_config_2/EnvironmentManager.py X-VCS-Directories: src/java_config_2/ X-VCS-Committer: sera X-VCS-Committer-Name: Ralph Sennhauser X-VCS-Revision: a98d389c9bbc5f691938780c22557533fb885e8b X-VCS-Branch: master Date: Sat, 28 Dec 2013 13:15:43 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: e656a25b-4619-4baf-bd11-3dd6c17a532a X-Archives-Hash: bbc57da79d72c2e7a68e60f9ecbe2658 commit: a98d389c9bbc5f691938780c22557533fb885e8b Author: Ralph Sennhauser gentoo org> AuthorDate: Sat Dec 28 10:49:39 2013 +0000 Commit: Ralph Sennhauser gentoo org> CommitDate: Sat Dec 28 12:28:00 2013 +0000 URL: http://git.overlays.gentoo.org/gitweb/?p=proj/java-config.git;a=commit;h=a98d389c Rename variable active to active_vm Self-documenting code is good --- src/java_config_2/EnvironmentManager.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/java_config_2/EnvironmentManager.py b/src/java_config_2/EnvironmentManager.py index ab83dd1..d573d64 100644 --- a/src/java_config_2/EnvironmentManager.py +++ b/src/java_config_2/EnvironmentManager.py @@ -24,7 +24,7 @@ class EnvironmentManager(object): self.virtuals = {} self.virtuals_pref = None self.virtual_machines = None - self.active = None + self.active_vm = None self.eprefix = eprefix self.eroot = root + eprefix @@ -107,7 +107,7 @@ class EnvironmentManager(object): if vm_name: vm = self.get_vm(vm_name) if vm: - self.active = vm + self.active_vm = vm return vm for link in self.vm_links(): @@ -115,17 +115,17 @@ class EnvironmentManager(object): vm_name = basename(os.readlink(link)) vm = self.get_vm(vm_name) if vm: - self.active = vm + self.active_vm = vm return vm raise InvalidVMError("Unable to determine valid vm. Please see http://www.gentoo.org/doc/en/java.xml#doc_chap4") def set_active_vm(self, vm): - self.active = vm + self.active_vm = vm def get_active_vm(self): - if self.active is None: + if self.active_vm is None: self.load_active_vm() - return self.active + return self.active_vm def get_virtual_machines(self): if self.virtual_machines is None: