From: "Brian Dolbec" <brian.dolbec@gmail.com>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/catalyst:rewrite-on-master commit in: catalyst/base/, catalyst/targets/
Date: Fri, 22 Nov 2013 07:13:25 +0000 (UTC) [thread overview]
Message-ID: <1385100109.1cba3b8ec73d458e53a65f0be7275f7585dc2186.dol-sen@gentoo> (raw)
commit: 1cba3b8ec73d458e53a65f0be7275f7585dc2186
Author: Brian Dolbec <dolsen <AT> gentoo <DOT> org>
AuthorDate: Sat Jun 1 07:31:59 2013 +0000
Commit: Brian Dolbec <brian.dolbec <AT> gmail <DOT> com>
CommitDate: Fri Nov 22 06:01:49 2013 +0000
URL: http://git.overlays.gentoo.org/gitweb/?p=proj/catalyst.git;a=commit;h=1cba3b8e
Rename local unpack var to _unpack
The method name was unpack, so rename the local var to _unpack to help avoid confusion.
---
catalyst/base/stagebase.py | 18 +++++++++---------
catalyst/targets/livecd_stage2.py | 6 +++---
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/catalyst/base/stagebase.py b/catalyst/base/stagebase.py
index 759afee..e2a98cf 100644
--- a/catalyst/base/stagebase.py
+++ b/catalyst/base/stagebase.py
@@ -657,7 +657,7 @@ class StageBase(TargetBase, ClearBase, GenBase):
target, print_traceback=True)
def unpack(self):
- unpack=True
+ _unpack=True
clst_unpack_hash = self.resume.get("unpack")
@@ -707,49 +707,49 @@ class StageBase(TargetBase, ClearBase, GenBase):
if os.path.isdir(self.settings["source_path"]) \
and self.resume.is_enabled("unpack"):
""" Autoresume is valid, SEEDCACHE is valid """
- unpack=False
+ _unpack=False
invalid_snapshot=False
elif os.path.isfile(self.settings["source_path"]) \
and self.settings["source_path_hash"]==clst_unpack_hash:
""" Autoresume is valid, tarball is valid """
- unpack=False
+ _unpack=False
invalid_snapshot=True
elif os.path.isdir(self.settings["source_path"]) \
and self.resume.is_disabled("unpack"):
""" Autoresume is invalid, SEEDCACHE """
- unpack=True
+ _unpack=True
invalid_snapshot=False
elif os.path.isfile(self.settings["source_path"]) \
and self.settings["source_path_hash"]!=clst_unpack_hash:
""" Autoresume is invalid, tarball """
- unpack=True
+ _unpack=True
invalid_snapshot=True
else:
""" No autoresume, SEEDCACHE """
if "seedcache" in self.settings["options"]:
""" SEEDCACHE so let's run rsync and let it clean up """
if os.path.isdir(self.settings["source_path"]):
- unpack=True
+ _unpack=True
invalid_snapshot=False
elif os.path.isfile(self.settings["source_path"]):
""" Tarball so unpack and remove anything already there """
- unpack=True
+ _unpack=True
invalid_snapshot=True
""" No autoresume, no SEEDCACHE """
else:
""" Tarball so unpack and remove anything already there """
if os.path.isfile(self.settings["source_path"]):
- unpack=True
+ _unpack=True
invalid_snapshot=True
elif os.path.isdir(self.settings["source_path"]):
""" We should never reach this, so something is very wrong """
raise CatalystError(
"source path is a dir but seedcache is not enabled")
- if unpack:
+ if _unpack:
self.mount_safety_check()
if invalid_snapshot:
diff --git a/catalyst/targets/livecd_stage2.py b/catalyst/targets/livecd_stage2.py
index 7e24bca..82c69b0 100644
--- a/catalyst/targets/livecd_stage2.py
+++ b/catalyst/targets/livecd_stage2.py
@@ -87,7 +87,7 @@ class livecd_stage2(StageBase):
myf.close()
def unpack(self):
- unpack=True
+ _unpack=True
display_msg=None
clst_unpack_hash = self.resume.get("unpack")
@@ -103,12 +103,12 @@ class livecd_stage2(StageBase):
if os.path.isdir(self.settings["source_path"]) and \
self.resume.is_enabled("unpack"):
print "Resume point detected, skipping unpack operation..."
- unpack=False
+ _unpack=False
elif "source_path_hash" in self.settings:
if self.settings["source_path_hash"] != clst_unpack_hash:
invalid_snapshot=True
- if unpack:
+ if _unpack:
self.mount_safety_check()
if invalid_snapshot:
print "No Valid Resume point detected, cleaning up ..."
next reply other threads:[~2013-11-22 7:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 7:13 Brian Dolbec [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-11-22 7:13 [gentoo-commits] proj/catalyst:rewrite-on-master commit in: catalyst/base/, catalyst/targets/ Brian Dolbec
2013-11-22 7:13 Brian Dolbec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385100109.1cba3b8ec73d458e53a65f0be7275f7585dc2186.dol-sen@gentoo \
--to=brian.dolbec@gmail.com \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox