public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Ulrich Müller" <ulm@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/eselect:master commit in: /, bin/
Date: Tue, 22 Oct 2013 17:04:49 +0000 (UTC)	[thread overview]
Message-ID: <1382461410.b1890839e5719c7affcaf22403073295c73aed98.ulm@gentoo> (raw)

commit:     b1890839e5719c7affcaf22403073295c73aed98
Author:     Ulrich Müller <ulm <AT> gentoo <DOT> org>
AuthorDate: Tue Oct 22 17:03:30 2013 +0000
Commit:     Ulrich Müller <ulm <AT> gentoo <DOT> org>
CommitDate: Tue Oct 22 17:03:30 2013 +0000
URL:        http://git.overlays.gentoo.org/gitweb/?p=proj/eselect.git;a=commit;h=b1890839

Remove deprecated es_do_list_{options,modules} functions.

* bin/eselect.in (es_do_list_options, es_do_list_modules):
Remove deprecated functions.
(es_do_help): Move code for listing options and modules to here.

---
 ChangeLog      |  6 ++++++
 bin/eselect.in | 28 +++++++++-------------------
 2 files changed, 15 insertions(+), 19 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 384c22a..f06969f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2013-10-22  Ulrich Müller  <ulm@gentoo.org>
+
+	* bin/eselect.in (es_do_list_options, es_do_list_modules):
+	Remove deprecated functions.
+	(es_do_help): Move code for listing options and modules to here.
+
 2013-10-21  Ulrich Müller  <ulm@gentoo.org>
 
 	* bin/eselect.in: Remove legacy --no-colour option.

diff --git a/bin/eselect.in b/bin/eselect.in
index d5ba828..b1dc5d9 100755
--- a/bin/eselect.in
+++ b/bin/eselect.in
@@ -82,9 +82,14 @@ es_do_help() {
 	set_output_mode default
 	es_do_usage
 	echo
-	es_do_list_options
+	# display all recognized global options
+	write_list_start "Global options:"
+	write_kv_list_entry "--brief" "Make output shorter"
+	write_kv_list_entry "--colour=<yes|no|auto>" \
+		"Enable or disable colour output (default 'auto')"
 	echo
-	es_do_list_modules
+	# display all available eselect modules
+	do_action modules list
 }
 
 # es_do_version
@@ -96,21 +101,6 @@ es_do_version() {
 	echo "Distributed under the terms of the GNU GPL version 2 or later."
 }
 
-# es_do_list_options
-# Display all recognized global options
-es_do_list_options() {
-	write_list_start "Global options:"
-	write_kv_list_entry "--brief" "Make output shorter"
-	write_kv_list_entry "--colour=<yes|no|auto>" \
-		"Enable or disable colour output (default 'auto')"
-}
-
-# es_do_list_modules
-# Display all available eselect modules DEPRECATED
-es_do_list_modules() {
-	do_action modules list "$@"
-}
-
 ### main code ###
 
 # figure out what the action is. we need to know whether we're
@@ -178,9 +168,9 @@ fi
 unset colour
 
 if [[ -n ${action} ]]; then
-	if is_function "es_do_${action//-/_}"; then
+	if is_function "es_do_${action}"; then
 		[[ $# -gt 0 ]] && die -q "Too many parameters"
-		es_do_${action//-/_}
+		es_do_${action}
 	else
 		do_action "${action}" "$@"
 	fi


             reply	other threads:[~2013-10-22 17:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-22 17:04 Ulrich Müller [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-01-05 20:59 [gentoo-commits] proj/eselect:master commit in: /, bin/ Ulrich Müller
2023-06-07  8:50 [gentoo-commits] proj/eselect:master commit in: bin/, / Ulrich Müller
2023-06-12 16:24 ` [gentoo-commits] proj/eselect:master commit in: /, bin/ Ulrich Müller
2023-06-05 18:34 Ulrich Müller
2014-06-05 11:22 Ulrich Müller
2013-10-22  8:30 Ulrich Müller
2013-10-22  8:47 ` Ulrich Müller
2013-08-08 20:59 Ulrich Mueller
2012-09-15 20:35 Ulrich Mueller
2012-09-13 17:11 Ulrich Mueller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1382461410.b1890839e5719c7affcaf22403073295c73aed98.ulm@gentoo \
    --to=ulm@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox