From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <gentoo-commits+bounces-636574-garchives=archives.gentoo.org@lists.gentoo.org> Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id CD60F1381F3 for <garchives@archives.gentoo.org>; Fri, 18 Oct 2013 21:54:43 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 62E3BE0C4B; Fri, 18 Oct 2013 21:54:43 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 0A90EE0C4B for <gentoo-commits@lists.gentoo.org>; Fri, 18 Oct 2013 21:54:42 +0000 (UTC) Received: from hornbill.gentoo.org (hornbill.gentoo.org [94.100.119.163]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 1F6D333F016 for <gentoo-commits@lists.gentoo.org>; Fri, 18 Oct 2013 21:54:42 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by hornbill.gentoo.org (Postfix) with ESMTP id C5B3EE5308 for <gentoo-commits@lists.gentoo.org>; Fri, 18 Oct 2013 21:54:40 +0000 (UTC) From: "William Hubbs" <williamh@gentoo.org> To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "William Hubbs" <williamh@gentoo.org> Message-ID: <1382131971.d2988dc7ddd832ffc94f6b76c54898217812b7cc.williamh@OpenRC> Subject: [gentoo-commits] proj/openrc:master commit in: init.d/ X-VCS-Repository: proj/openrc X-VCS-Files: init.d/localmount.in init.d/mount-ro.in X-VCS-Directories: init.d/ X-VCS-Committer: williamh X-VCS-Committer-Name: William Hubbs X-VCS-Revision: d2988dc7ddd832ffc94f6b76c54898217812b7cc X-VCS-Branch: master Date: Fri, 18 Oct 2013 21:54:40 +0000 (UTC) Precedence: bulk List-Post: <mailto:gentoo-commits@lists.gentoo.org> List-Help: <mailto:gentoo-commits+help@lists.gentoo.org> List-Unsubscribe: <mailto:gentoo-commits+unsubscribe@lists.gentoo.org> List-Subscribe: <mailto:gentoo-commits+subscribe@lists.gentoo.org> List-Id: Gentoo Linux mail <gentoo-commits.gentoo.org> X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: 4afcfd44-40c5-45b6-9992-cc2872031896 X-Archives-Hash: 73ad2cda12c5f49148f959d4d2ffc906 commit: d2988dc7ddd832ffc94f6b76c54898217812b7cc Author: William Hubbs <w.d.hubbs <AT> gmail <DOT> com> AuthorDate: Fri Oct 18 21:26:46 2013 +0000 Commit: William Hubbs <williamh <AT> gentoo <DOT> org> CommitDate: Fri Oct 18 21:32:51 2013 +0000 URL: http://git.overlays.gentoo.org/gitweb/?p=proj/openrc.git;a=commit;h=d2988dc7 remove redundant sync calls The localmount and mount-ro scripts were flushing pending disk writes by calling sync twice in succession. This is no longer necessary; see the bug report and blog post for reasons we were still doing this. Reported-by: Patrick Lauer <patrick <AT> gentoo.org> X-Gentoo-Bug: 487382 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=487382 --- init.d/localmount.in | 2 +- init.d/mount-ro.in | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/init.d/localmount.in b/init.d/localmount.in index 5444889..42b7988 100644 --- a/init.d/localmount.in +++ b/init.d/localmount.in @@ -59,7 +59,7 @@ stop() no_umounts_r="^($no_umounts_r)$" # Flush all pending disk writes now - sync; sync + sync . "$RC_LIBEXECDIR"/sh/rc-mount.sh diff --git a/init.d/mount-ro.in b/init.d/mount-ro.in index f8d7258..3e09352 100644 --- a/init.d/mount-ro.in +++ b/init.d/mount-ro.in @@ -15,7 +15,7 @@ start() local ret=0 # Flush all pending disk writes now - sync; sync + sync ebegin "Remounting remaining filesystems read-only" # We need the do_unmount function