From: "André Erdmann" <dywi@mailerd.de>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/R_overlay:master commit in: roverlay/overlay/pkgdir/
Date: Tue, 17 Sep 2013 13:49:23 +0000 (UTC) [thread overview]
Message-ID: <1379344871.e3d569207defdb63ca7c1c3fa8f672321ed5070d.dywi@gentoo> (raw)
commit: e3d569207defdb63ca7c1c3fa8f672321ed5070d
Author: André Erdmann <dywi <AT> mailerd <DOT> de>
AuthorDate: Mon Sep 16 15:20:26 2013 +0000
Commit: André Erdmann <dywi <AT> mailerd <DOT> de>
CommitDate: Mon Sep 16 15:21:11 2013 +0000
URL: http://git.overlays.gentoo.org/gitweb/?p=proj/R_overlay.git;a=commit;h=e3d56920
packagedir_base: add note about incorrect stats
---
roverlay/overlay/pkgdir/packagedir_base.py | 36 ++++++++++++++++++++----------
1 file changed, 24 insertions(+), 12 deletions(-)
diff --git a/roverlay/overlay/pkgdir/packagedir_base.py b/roverlay/overlay/pkgdir/packagedir_base.py
index 870a419..27f395c 100644
--- a/roverlay/overlay/pkgdir/packagedir_base.py
+++ b/roverlay/overlay/pkgdir/packagedir_base.py
@@ -787,6 +787,29 @@ class PackageDirBase ( roverlay.overlay.base.OverlayObject ):
if not nosync and not self.fetch_src_for_ebuild ( efile_dest ):
raise Exception ( "doebuild_fetch() failed." )
+ # link files to distroot/distmap
+ #
+ # NOTE: the stats count imported ebuilds without any src file
+ # (nosync=True and $SRC_URI not empty) as successful
+ # (stats_ebuild_imported() below), whereas these ebuilds
+ # will be ignored when running roverlay again.
+ #
+ # This could be fixed by checking whether
+ # DISTROOT.set_distfile_owner() returns a virtual entry,
+ # but use-dependent could be virtual, too.
+ #
+ for distfile in p.parse_ebuild_distfiles (
+ self.get_parent().name,
+ ignore_unparseable=True, yield_unparseable=True
+ ):
+ if distfile is None:
+ self.DISTROOT.need_distmap_sync()
+ else:
+ self.DISTROOT.set_distfile_owner (
+ self.get_ref(), distfile
+ )
+ # -- end for
+
except:
# this package dir is "broken" now,
# so a new manifest would be good...
@@ -809,18 +832,7 @@ class PackageDirBase ( roverlay.overlay.base.OverlayObject ):
stats_ebuild_imported()
efile_imported ( efile_dest )
-
-
- # link files to distroot/distmap (if possible)
- for distfile in p.parse_ebuild_distfiles (
- self.get_parent().name,
- ignore_unparseable=True, yield_unparseable=True
- ):
- if distfile is None:
- self.DISTROOT.need_distmap_sync()
- else:
- self.DISTROOT.set_distfile_owner ( self.get_ref(), distfile )
- # -- end for
+ # -- end try
return p
# --- end of import_ebuild_efile (...) ---
next reply other threads:[~2013-09-17 13:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 13:49 André Erdmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-02-18 16:33 [gentoo-commits] proj/R_overlay:master commit in: roverlay/overlay/pkgdir/ André Erdmann
2015-01-26 17:41 André Erdmann
2014-08-23 19:03 André Erdmann
2014-07-29 18:29 ` André Erdmann
2014-07-18 16:20 André Erdmann
2014-07-18 2:28 [gentoo-commits] proj/R_overlay:wip/addition_control " André Erdmann
2014-07-18 16:20 ` [gentoo-commits] proj/R_overlay:master " André Erdmann
2013-09-03 15:51 André Erdmann
2013-08-30 15:28 André Erdmann
2013-08-29 12:36 André Erdmann
2013-08-29 12:36 André Erdmann
2013-08-29 12:36 André Erdmann
2013-08-28 15:54 André Erdmann
2013-08-28 9:38 André Erdmann
2013-08-07 16:10 André Erdmann
2013-08-06 16:02 André Erdmann
2013-07-10 16:16 André Erdmann
2013-07-10 16:16 André Erdmann
2013-07-10 16:16 [gentoo-commits] proj/R_overlay:gsoc13/next " André Erdmann
2013-07-10 16:16 ` [gentoo-commits] proj/R_overlay:master " André Erdmann
2013-07-10 16:16 [gentoo-commits] proj/R_overlay:gsoc13/next " André Erdmann
2013-07-10 16:16 ` [gentoo-commits] proj/R_overlay:master " André Erdmann
2013-06-13 16:34 André Erdmann
2013-04-25 16:44 André Erdmann
2013-02-09 20:45 André Erdmann
2013-02-05 20:39 André Erdmann
2013-01-28 23:54 André Erdmann
2013-01-28 23:54 André Erdmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379344871.e3d569207defdb63ca7c1c3fa8f672321ed5070d.dywi@gentoo \
--to=dywi@mailerd.de \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox