public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "André Erdmann" <dywi@mailerd.de>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/R_overlay:master commit in: files/hooks/
Date: Fri,  6 Sep 2013 10:22:05 +0000 (UTC)	[thread overview]
Message-ID: <1378462851.e24b74fa8ebecf2338d01b2acc824a7683c5a809.dywi@gentoo> (raw)

commit:     e24b74fa8ebecf2338d01b2acc824a7683c5a809
Author:     André Erdmann <dywi <AT> mailerd <DOT> de>
AuthorDate: Fri Sep  6 10:20:51 2013 +0000
Commit:     André Erdmann <dywi <AT> mailerd <DOT> de>
CommitDate: Fri Sep  6 10:20:51 2013 +0000
URL:        http://git.overlays.gentoo.org/gitweb/?p=proj/R_overlay.git;a=commit;h=e24b74fa

git-push: return 0 even if git push failed

+ remove "echo" in the git push command

---
 files/hooks/git-push.sh | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/files/hooks/git-push.sh b/files/hooks/git-push.sh
index 2dbb73e..e65d861 100644
--- a/files/hooks/git-push.sh
+++ b/files/hooks/git-push.sh
@@ -24,7 +24,7 @@ $lf itertools
 #  if errors occured.
 #
 git_push_to_remote() {
-   if run_command_logged echo ${GIT} push ${GIT_PUSH_ARGS-} "$@"; then
+   if run_command_logged ${GIT} push ${GIT_PUSH_ARGS-} "$@"; then
       veinfo "successfully pushed changes to ${1}"
    else
       __GIT_PUSH_SUCCESS=n
@@ -55,15 +55,16 @@ git_push_to_remotes() {
    if [ "${__GIT_PUSH_SUCCESS}" = "y" ]; then
       return 0
    else
-      return ${EX_GIT_PUSH_ERR}
+      # don't return non-zero due to "git push" errors
+      #  this would cause roverlay to abort
+      #return ${EX_GIT_PUSH_ERR}
+      return 0
    fi
 }
 
 
 ## main
 
-if yesno "${NOSYNC?}"; then
-   einfo "sync is disabled - not pushing anything."
-else
+if sync_allowed "${this}"; then
    git_push_to_remotes
 fi


             reply	other threads:[~2013-09-06 10:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-06 10:22 André Erdmann [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-04-01 16:38 [gentoo-commits] proj/R_overlay:master commit in: files/hooks/ André Erdmann
2014-01-25 18:14 André Erdmann
2013-09-23 15:30 André Erdmann
2013-09-06 11:10 André Erdmann
2013-09-06 11:10 André Erdmann
2013-09-06 10:22 André Erdmann
2013-09-06 10:22 André Erdmann
2013-09-04 13:13 André Erdmann
2013-09-04 12:50 André Erdmann
2013-09-04 10:16 André Erdmann
2013-08-02 10:34 André Erdmann
2013-06-22 15:24 André Erdmann
2013-06-22 15:24 André Erdmann
2013-06-21 18:41 [gentoo-commits] proj/R_overlay:gsoc13/next " André Erdmann
2013-06-22 15:24 ` [gentoo-commits] proj/R_overlay:master " André Erdmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378462851.e24b74fa8ebecf2338d01b2acc824a7683c5a809.dywi@gentoo \
    --to=dywi@mailerd.de \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox