From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 9B99F1381F3 for ; Sat, 6 Jul 2013 22:06:56 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 34492E0A43; Sat, 6 Jul 2013 22:06:51 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id B8F2FE0A43 for ; Sat, 6 Jul 2013 22:06:50 +0000 (UTC) Received: from hornbill.gentoo.org (hornbill.gentoo.org [94.100.119.163]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id B993333E833 for ; Sat, 6 Jul 2013 22:06:49 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by hornbill.gentoo.org (Postfix) with ESMTP id 55216E468F for ; Sat, 6 Jul 2013 22:06:48 +0000 (UTC) From: "Zac Medico" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Zac Medico" Message-ID: <1373148388.30c655321dbb75b97348aa1f28f9049237592079.zmedico@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: pym/portage/package/ebuild/ X-VCS-Repository: proj/portage X-VCS-Files: pym/portage/package/ebuild/doebuild.py X-VCS-Directories: pym/portage/package/ebuild/ X-VCS-Committer: zmedico X-VCS-Committer-Name: Zac Medico X-VCS-Revision: 30c655321dbb75b97348aa1f28f9049237592079 X-VCS-Branch: master Date: Sat, 6 Jul 2013 22:06:48 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: e1cc3df5-7ca1-408b-87f2-03e31d9e13ec X-Archives-Hash: 10daf1c4bd23c5ccbd5dbb9481c48758 commit: 30c655321dbb75b97348aa1f28f9049237592079 Author: Zac Medico gentoo org> AuthorDate: Sat Jul 6 22:06:28 2013 +0000 Commit: Zac Medico gentoo org> CommitDate: Sat Jul 6 22:06:28 2013 +0000 URL: http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=30c65532 doebuild: deprecate returnpid This case is not supported, since it bypasses the EbuildPhase class which implements important functionality (including post phase hooks and IPC for things like best/has_version and die). --- pym/portage/package/ebuild/doebuild.py | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/pym/portage/package/ebuild/doebuild.py b/pym/portage/package/ebuild/doebuild.py index 8444e19..23ca238 100644 --- a/pym/portage/package/ebuild/doebuild.py +++ b/pym/portage/package/ebuild/doebuild.py @@ -583,6 +583,15 @@ def doebuild(myebuild, mydo, _unused=DeprecationWarning, settings=None, debug=0, writemsg("\n", noiselevel=-1) return 1 + if returnpid and mydo != 'depend': + # This case is not supported, since it bypasses the EbuildPhase class + # which implements important functionality (including post phase hooks + # and IPC for things like best/has_version and die). + warnings.warn("portage.doebuild() called " + "with returnpid parameter enabled. This usage will " + "not be supported in the future.", + DeprecationWarning, stacklevel=2) + if mydo == "fetchall": fetchall = 1 mydo = "fetch" @@ -1507,6 +1516,12 @@ def spawn(mystring, mysettings, debug=0, free=0, droppriv=0, sesandbox=0, fakero def spawnebuild(mydo, actionmap, mysettings, debug, alwaysdep=0, logfile=None, fd_pipes=None, returnpid=False): + if returnpid: + warnings.warn("portage.spawnebuild() called " + "with returnpid parameter enabled. This usage will " + "not be supported in the future.", + DeprecationWarning, stacklevel=2) + if not returnpid and \ (alwaysdep or "noauto" not in mysettings.features): # process dependency first