From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 753AE1381F3 for ; Sat, 11 May 2013 19:11:26 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 03365E087A; Sat, 11 May 2013 19:11:26 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 98E65E087A for ; Sat, 11 May 2013 19:11:25 +0000 (UTC) Received: from hornbill.gentoo.org (hornbill.gentoo.org [94.100.119.163]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id B2D0233E01E for ; Sat, 11 May 2013 19:11:24 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by hornbill.gentoo.org (Postfix) with ESMTP id 4F6CAE52A1 for ; Sat, 11 May 2013 19:11:23 +0000 (UTC) From: "Christian Ruppert" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Christian Ruppert" Message-ID: <1368299472.ea8d02eb24a636b0974bff595c9574a426b86ae5.idl0r@gentoo> Subject: [gentoo-commits] proj/gentoolkit:gentoolkit-dev commit in: src/echangelog/ X-VCS-Repository: proj/gentoolkit X-VCS-Files: src/echangelog/echangelog X-VCS-Directories: src/echangelog/ X-VCS-Committer: idl0r X-VCS-Committer-Name: Christian Ruppert X-VCS-Revision: ea8d02eb24a636b0974bff595c9574a426b86ae5 X-VCS-Branch: gentoolkit-dev Date: Sat, 11 May 2013 19:11:23 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: 9fa8e084-4e72-49bf-9fbb-cf2cb86abdd4 X-Archives-Hash: 93d29ddc997d9c1fa45a6988ccfa20b0 commit: ea8d02eb24a636b0974bff595c9574a426b86ae5 Author: Christian Ruppert gentoo org> AuthorDate: Sat May 11 19:11:12 2013 +0000 Commit: Christian Ruppert gentoo org> CommitDate: Sat May 11 19:11:12 2013 +0000 URL: http://git.overlays.gentoo.org/gitweb/?p=proj/gentoolkit.git;a=commit;h=ea8d02eb Refactor pipe handle close --- src/echangelog/echangelog | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/echangelog/echangelog b/src/echangelog/echangelog index d6cb205..ab3c475 100755 --- a/src/echangelog/echangelog +++ b/src/echangelog/echangelog @@ -520,8 +520,8 @@ sub sortfunc($$) { @ebuilds = grep(/\.ebuild$/, @files); @files = grep(!/\.ebuild$/, @files); -my $ph_diff; if (@ebuilds) { + my $ph_diff; if ($vcs eq "git") { open($ph_diff, "-|", $vcs{$vcs}{diff}." HEAD -- @ebuilds 2>&1") or die "Can't run: ".$vcs{$vcs}{diff}."$!\n"; } else { @@ -593,8 +593,8 @@ if (@ebuilds) { mypush(@new_versions, $2); } } + close($ph_diff); } -close($ph_diff) if $ph_diff; # Subversion diff doesn't identify new versions. So use the status command if (($vcs eq "svn" or $vcs eq "hg") and (@ebuilds)) {