From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id C854F198005 for ; Sat, 16 Mar 2013 05:39:58 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 2BBFFE0529; Sat, 16 Mar 2013 05:39:57 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id B7977E0529 for ; Sat, 16 Mar 2013 05:39:56 +0000 (UTC) Received: from hornbill.gentoo.org (hornbill.gentoo.org [94.100.119.163]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id C892C33DB78 for ; Sat, 16 Mar 2013 05:39:55 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by hornbill.gentoo.org (Postfix) with ESMTP id A3C61E4079 for ; Sat, 16 Mar 2013 05:39:51 +0000 (UTC) From: "Zac Medico" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Zac Medico" Message-ID: <1363412378.8cfe2dc28e02a9cdd739a83db4ed871a31468114.zmedico@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: pym/portage/dbapi/ X-VCS-Repository: proj/portage X-VCS-Files: pym/portage/dbapi/vartree.py X-VCS-Directories: pym/portage/dbapi/ X-VCS-Committer: zmedico X-VCS-Committer-Name: Zac Medico X-VCS-Revision: 8cfe2dc28e02a9cdd739a83db4ed871a31468114 X-VCS-Branch: master Date: Sat, 16 Mar 2013 05:39:51 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: ad0ddab9-ddd2-4c43-bdd2-72e84fd8ccdd X-Archives-Hash: eb9039c576f143ead0175f9db90c5ff2 commit: 8cfe2dc28e02a9cdd739a83db4ed871a31468114 Author: Zac Medico gentoo org> AuthorDate: Sat Mar 16 05:39:38 2013 +0000 Commit: Zac Medico gentoo org> CommitDate: Sat Mar 16 05:39:38 2013 +0000 URL: http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=8cfe2dc2 Use lexists for symlink target checks. --- pym/portage/dbapi/vartree.py | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/pym/portage/dbapi/vartree.py b/pym/portage/dbapi/vartree.py index 95b67dd..d011c33 100644 --- a/pym/portage/dbapi/vartree.py +++ b/pym/portage/dbapi/vartree.py @@ -4484,7 +4484,10 @@ class dblink(object): pass if mymtime != None: - if not os.path.exists(myrealto) and not os.path.exists(join(srcroot, myabsto)): + # Use lexists, since if the target happens to be a broken + # symlink then that should trigger an independent warning. + if not (os.path.lexists(myrealto) or + os.path.lexists(join(srcroot, myabsto))): self._eqawarn('preinst', [_("QA Notice: Symbolic link /%s points to /%s which does not exist.") % (relative_path, myabsto)])