From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 3D658198005 for ; Sat, 9 Mar 2013 12:31:13 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 7F578E073F; Sat, 9 Mar 2013 12:31:12 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id E7976E073F for ; Sat, 9 Mar 2013 12:31:11 +0000 (UTC) Received: from hornbill.gentoo.org (hornbill.gentoo.org [94.100.119.163]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id D35F133DBD2 for ; Sat, 9 Mar 2013 12:31:10 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by hornbill.gentoo.org (Postfix) with ESMTP id 78019E41E2 for ; Sat, 9 Mar 2013 12:31:09 +0000 (UTC) From: "Ulrich Mueller" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Ulrich Mueller" Message-ID: <1362828315.e6304fcfd6b0b4fda10289d303b36a7164adf93d.ulm@gentoo> Subject: [gentoo-commits] proj/emacs-tools:emacs-updater commit in: / X-VCS-Repository: proj/emacs-tools X-VCS-Files: ChangeLog emacs-updater X-VCS-Directories: / X-VCS-Committer: ulm X-VCS-Committer-Name: Ulrich Mueller X-VCS-Revision: e6304fcfd6b0b4fda10289d303b36a7164adf93d X-VCS-Branch: emacs-updater Date: Sat, 9 Mar 2013 12:31:09 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: bcbc9942-ce89-4664-9179-d7fd02d7ac92 X-Archives-Hash: 1cb7a450244a443880d6f9f51c660bc7 commit: e6304fcfd6b0b4fda10289d303b36a7164adf93d Author: Ulrich Müller gentoo org> AuthorDate: Sat Mar 9 11:25:15 2013 +0000 Commit: Ulrich Mueller gentoo org> CommitDate: Sat Mar 9 11:25:15 2013 +0000 URL: http://git.overlays.gentoo.org/gitweb/?p=proj/emacs-tools.git;a=commit;h=e6304fcf Remove unneccesary quoting. * emacs-updater: Remove unneccesary quoting. --- ChangeLog | 4 ++++ emacs-updater | 26 +++++++++++++------------- 2 files changed, 17 insertions(+), 13 deletions(-) diff --git a/ChangeLog b/ChangeLog index 72cb580..a17828a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2013-03-09 Ulrich Müller + + * emacs-updater: Remove unneccesary quoting. + 2012-10-11 Ulrich Müller * Version 1.10 released. diff --git a/emacs-updater b/emacs-updater index 21329d0..ac42692 100755 --- a/emacs-updater +++ b/emacs-updater @@ -61,7 +61,7 @@ usage() { X X -- OPTION... Pass additional options to package manager EOF - exit ${1} + exit $1 } version() { @@ -113,7 +113,7 @@ eval set -- "${OPTIONS}" while true do - case "${1}" in + case $1 in -h|--help) usage 0 ;; --version) version ;; -b|--batch) BATCH="true"; shift ;; @@ -125,7 +125,7 @@ do -a|--action) ACTIONS= for action in ${2/,/ }; do - case "${action}" in + case ${action} in sitedir|rebuild|all) ACTIONS="${ACTIONS}${ACTIONS:+ }${action}" ;; @@ -138,27 +138,27 @@ do shift 2 ;; -P|--package-manager) - case "${2}" in + case $2 in auto|automatic) PM_COMMAND=pm_auto ;; portage|pkgcore|paludis) - if ! have_${2}; then - echo "Package manager '${2}' not found!" + if ! have_$2; then + echo "Package manager '$2' not found!" exit 22 fi - PM_COMMAND=pm_${2} + PM_COMMAND=pm_$2 ;; *) - echo "Package manager '${2}' not known!" + echo "Package manager '$2' not known!" usage 21 ;; esac shift 2 ;; - --package-manager-command) PM_COMMAND=${2}; shift 2 ;; + --package-manager-command) PM_COMMAND=$2; shift 2 ;; --) shift; PM_EXTRAOPTS=( "$@" ); break ;; *) # this should not happen; getopt should return bad status - echo "Invalid option '${1}' given!" + echo "Invalid option '$1' given!" usage 22 ;; esac @@ -202,7 +202,7 @@ emacs_version() { # Get Emacs version from byte-compiled file bytecomp_version() { - sed -n '/^[^;]/q;s/\.$//;s/.*[Ee]macs version \([0-9].*\)/\1/p' "${1}" + sed -n '/^[^;]/q;s/\.$//;s/.*[Ee]macs version \([0-9].*\)/\1/p' "$1" } action_sitedir() { @@ -239,7 +239,7 @@ action_rebuild() { if [ -z "${MAJOR}" -a "${version%.*}" != "${active%.*}" ] \ || [ "${version%%.*}" != "${active%%.*}" ] \ - || [ "${1}" = all ] + || [ "$1" = all ] then echo "Found ${elc##*/} (compiled by Emacs ${version})" echo "${elc}" >> "${TMPFILE}" @@ -311,7 +311,7 @@ else echo -n "${BOLD}Remerge packages?${NORMAL} [${GREEN}Yes${NORMAL}/${RED}No${NORMAL}] " read choice echo - case "${choice}" in + case ${choice} in y*|Y*|"") ;; *) warning "Quitting."; exit 10 ;; esac