[gentoo-commits] proj/qemu-kvm:qemu-kvm-1.2.0-gentoo commit in: /

["Doug Goldstein" <cardoe@gentoo.org>]

commit:     9489a8c013cb96f6dc8b4fd3f8fe63d0afe9f8dd
Author:     Doug Goldstein <cardoe <AT> cardoe <DOT> com>
AuthorDate: Mon Oct 29 05:55:53 2012 +0000
Commit:     Doug Goldstein <cardoe <AT> gentoo <DOT> org>
CommitDate: Sat Jan 19 03:02:09 2013 +0000
URL:        http://git.overlays.gentoo.org/gitweb/?p=proj/qemu-kvm.git;a=commit;h=9489a8c0

migrate: error message for ram_load size

Report an error when ramblock's sizes mismatch with a suggestion to the
user as to what went wrong. If a user has a managedsave state by
libvirt, which is the default now, and upgrades their distro, which in
turn upgrades QEMU, they will be surprised by the fact that their VMs fail
to start. The reason for this is that the default ROM sizes changed
recently which makes it not possible to migrate from that saved state.
However the error message really does not provide details as to what
went wrong. This patch attempts to provide more details

see:
http://lists.nongnu.org/archive/html/qemu-devel/2012-10/msg03746.html
http://lists.nongnu.org/archive/html/qemu-devel/2012-10/msg04108.html

Signed-off-by: Doug Goldstein <cardoe <AT> cardoe.com>
(cherry picked from commit 4a9f00c12caa9e28992d76c18aeec468295bb157)

---
 arch_init.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/arch_init.c b/arch_init.c
index 5c91294..9befdb7 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -732,6 +732,11 @@ static int ram_load(QEMUFile *f, void *opaque, int version_id)
                     QLIST_FOREACH(block, &ram_list.blocks, next) {
                         if (!strncmp(id, block->idstr, sizeof(id))) {
                             if (block->length != length) {
+                                fprintf(stderr, "qemu: warning: error ramblock "
+                                        "'%s' length %ld != %ld. Did you "
+                                        "change the ROM/BIOS or RAM size "
+                                        "between restarts?\n", id,
+                                        block->length, length);
                                 ret =  -EINVAL;
                                 goto done;
                             }