From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 718CD138202 for ; Tue, 6 Nov 2012 23:20:08 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 68CCE21C016; Tue, 6 Nov 2012 23:19:50 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id B1A7D21C016 for ; Tue, 6 Nov 2012 23:19:49 +0000 (UTC) Received: from hornbill.gentoo.org (hornbill.gentoo.org [94.100.119.163]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id C9C6633DC17 for ; Tue, 6 Nov 2012 23:19:48 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by hornbill.gentoo.org (Postfix) with ESMTP id 643CFE5442 for ; Tue, 6 Nov 2012 23:19:47 +0000 (UTC) From: "Robin H. Johnson" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Robin H. Johnson" Message-ID: <1352243544.91e28ab775e2bcfb343ba2e2c8b7db0289e11f70.robbat2@OpenRC> Subject: [gentoo-commits] proj/openrc:master commit in: init.d/ X-VCS-Repository: proj/openrc X-VCS-Files: init.d/hostname.in X-VCS-Directories: init.d/ X-VCS-Committer: robbat2 X-VCS-Committer-Name: Robin H. Johnson X-VCS-Revision: 91e28ab775e2bcfb343ba2e2c8b7db0289e11f70 X-VCS-Branch: master Date: Tue, 6 Nov 2012 23:19:47 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: abc5467a-6572-4695-9bc0-1ce053711aab X-Archives-Hash: 31d895bf822374d02c80c2afdef6103c commit: 91e28ab775e2bcfb343ba2e2c8b7db0289e11f70 Author: Robin H. Johnson gentoo org> AuthorDate: Tue Nov 6 23:11:58 2012 +0000 Commit: Robin H. Johnson gentoo org> CommitDate: Tue Nov 6 23:12:24 2012 +0000 URL: http://git.overlays.gentoo.org/gitweb/?p=proj/openrc.git;a=commit;h=91e28ab7 init.d/hostname: Document checkbashism false positive. Signed-off-by: Robin H. Johnson gentoo.org> --- init.d/hostname.in | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/init.d/hostname.in b/init.d/hostname.in index 2b0ec81..5d8ce28 100644 --- a/init.d/hostname.in +++ b/init.d/hostname.in @@ -10,7 +10,9 @@ depend() { start() { - hostname=${hostname-${HOSTNAME-localhost}} + # HOSTNAME variable used to be defined in caps in conf.d/hostname. + # It is also a magic variable in bash. + hostname=${hostname-${HOSTNAME-localhost}} # checkbashisms: false positive ebegin "Setting hostname to $hostname" hostname "$hostname" eend $? "Failed to set the hostname"