public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Alexandre Restovtsev" <tetromino@gmail.com>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/openrc-settingsd:master commit in: src/
Date: Wed,  5 Sep 2012 16:54:24 +0000 (UTC)	[thread overview]
Message-ID: <1346861557.85d40b110c5ae791d1d0c7546adf632bcae032b4.tetromino@gentoo> (raw)

commit:     85d40b110c5ae791d1d0c7546adf632bcae032b4
Author:     Alexandre Rostovtsev <tetromino <AT> gentoo <DOT> org>
AuthorDate: Wed Sep  5 16:12:37 2012 +0000
Commit:     Alexandre Restovtsev <tetromino <AT> gmail <DOT> com>
CommitDate: Wed Sep  5 16:12:37 2012 +0000
URL:        http://git.overlays.gentoo.org/gitweb/?p=proj/openrc-settingsd.git;a=commit;h=85d40b11

Cleanup to make valgrind happy

---
 src/shell-utils.c |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/shell-utils.c b/src/shell-utils.c
index 545c5dd..f5c9b20 100644
--- a/src/shell-utils.c
+++ b/src/shell-utils.c
@@ -54,7 +54,7 @@ shell_utils_source_var (GFile *file,
                         GError **error)
 {
     gchar *argv[4] = { "sh", "-c", NULL, NULL };
-    gchar *filename, *quoted_filename;
+    gchar *filename = NULL, *quoted_filename = NULL;
     gchar *output = NULL;
     GFileInfo *info;
     const GFileAttributeInfo *attribute_info;
@@ -88,10 +88,8 @@ shell_utils_source_var (GFile *file,
     }
 
   out:
-    if (filename != NULL)
-        g_free (filename);
-    if (quoted_filename != NULL)
-        g_free (quoted_filename);
+    g_free (filename);
+    g_free (quoted_filename);
     if (info != NULL)
         g_object_unref (info);
     if (argv[2] != NULL)


             reply	other threads:[~2012-09-05 16:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-05 16:54 Alexandre Restovtsev [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-09-09  3:47 [gentoo-commits] proj/openrc-settingsd:master commit in: src/ Alexandre Rostovtsev
2012-09-08  0:20 Alexandre Restovtsev
2012-09-05 23:46 Alexandre Restovtsev
2012-09-05 21:19 Alexandre Restovtsev
2012-09-05 21:19 Alexandre Restovtsev
2012-09-05 21:19 Alexandre Restovtsev
2012-03-19  3:03 Alexandre Restovtsev
2012-03-19  2:05 Alexandre Restovtsev
2012-03-18 11:02 Alexandre Restovtsev
2012-02-08  6:53 Alexandre Restovtsev
2012-02-08  5:57 Alexandre Restovtsev
2012-02-08  5:01 Alexandre Restovtsev
2012-02-06 10:24 Alexandre Restovtsev
2012-02-05  7:52 Alexandre Restovtsev
2012-02-05  0:20 Alexandre Restovtsev
2012-01-29 23:22 Alexandre Restovtsev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1346861557.85d40b110c5ae791d1d0c7546adf632bcae032b4.tetromino@gentoo \
    --to=tetromino@gmail.com \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox