From: "Zac Medico" <zmedico@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/portage:master commit in: bin/ebuild-helpers/, bin/
Date: Sun, 2 Sep 2012 22:57:05 +0000 (UTC) [thread overview]
Message-ID: <1346626606.d184c0f32eba2eec3a8d28ae71be79aa635db147.zmedico@gentoo> (raw)
commit: d184c0f32eba2eec3a8d28ae71be79aa635db147
Author: Zac Medico <zmedico <AT> gentoo <DOT> org>
AuthorDate: Sun Sep 2 22:56:46 2012 +0000
Commit: Zac Medico <zmedico <AT> gentoo <DOT> org>
CommitDate: Sun Sep 2 22:56:46 2012 +0000
URL: http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=d184c0f3
Quote ${EAPI} more.
This will avoid a potential syntax error in save-ebuild-env.sh if a
saved environment containing corrupt EAPI is sourced.
---
| 2 +-
bin/ebuild-helpers/newins | 2 +-
bin/phase-functions.sh | 6 +++---
bin/phase-helpers.sh | 2 +-
bin/save-ebuild-env.sh | 2 +-
5 files changed, 7 insertions(+), 7 deletions(-)
--git a/bin/ebuild-helpers/doheader b/bin/ebuild-helpers/doheader
index 9bbe5bc..c51ec1e 100755
--- a/bin/ebuild-helpers/doheader
+++ b/bin/ebuild-helpers/doheader
@@ -4,7 +4,7 @@
source "${PORTAGE_BIN_PATH:-/usr/lib/portage/bin}"/isolated-functions.sh
-case ${EAPI} in
+case "${EAPI}" in
0|1|2|3|4|4-python|4-slot-abi)
die "${0##*/} is not supported in EAPI ${EAPI}"
;;
diff --git a/bin/ebuild-helpers/newins b/bin/ebuild-helpers/newins
index 2dc041d..54245f3 100755
--- a/bin/ebuild-helpers/newins
+++ b/bin/ebuild-helpers/newins
@@ -15,7 +15,7 @@ fi
eqawarn "QA Notice: ${helper} called with more than 2 arguments: ${@:3}"
stdin=
-case ${EAPI} in
+case "${EAPI}" in
0|1|2|3|4|4-python|4-slot-abi) ;;
*) [[ $1 = "-" ]] && stdin=yes ;;
esac
diff --git a/bin/phase-functions.sh b/bin/phase-functions.sh
index fd7fb25..68a33a8 100644
--- a/bin/phase-functions.sh
+++ b/bin/phase-functions.sh
@@ -755,12 +755,12 @@ _ebuild_phase_funcs() {
eval "$x() { _eapi0_$x \"\$@\" ; }"
done
- case $eapi in
+ case "$eapi" in
0|1)
if ! declare -F src_compile >/dev/null ; then
- case $eapi in
+ case "$eapi" in
0)
src_compile() { _eapi0_src_compile "$@" ; }
;;
@@ -807,7 +807,7 @@ _ebuild_phase_funcs() {
eval "default() { _eapi2_$phase_func \"\$@\" ; }"
- case $eapi in
+ case "$eapi" in
2|3)
;;
*)
diff --git a/bin/phase-helpers.sh b/bin/phase-helpers.sh
index 46f7132..0587991 100644
--- a/bin/phase-helpers.sh
+++ b/bin/phase-helpers.sh
@@ -174,7 +174,7 @@ usev() {
return 1
}
-case ${EAPI} in
+case "${EAPI}" in
0|1|2|3|4|4-python|4-slot-abi) ;;
*)
usex() {
diff --git a/bin/save-ebuild-env.sh b/bin/save-ebuild-env.sh
index 75e4843..6d6ed41 100644
--- a/bin/save-ebuild-env.sh
+++ b/bin/save-ebuild-env.sh
@@ -73,7 +73,7 @@ save_ebuild_env() {
_hasg _hasgq _unpack_tar \
${QA_INTERCEPTORS}
- case ${EAPI} in
+ case "${EAPI}" in
0|1|2|3|4|4-python|4-slot-abi) ;;
*) unset -f usex ;;
esac
next reply other threads:[~2012-09-02 22:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-02 22:57 Zac Medico [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-06-01 11:14 [gentoo-commits] proj/portage:master commit in: bin/ebuild-helpers/, bin/ Ulrich Müller
2023-10-21 19:23 Ulrich Müller
2021-05-24 4:55 Zac Medico
2018-09-20 18:49 Michał Górny
2018-03-28 5:19 Zac Medico
2018-03-04 21:05 Michał Górny
2014-12-04 14:01 Michał Górny
2014-08-19 7:01 Michał Górny
2014-08-10 0:10 Brian Dolbec
2013-05-12 20:47 Zac Medico
2013-05-12 11:16 Zac Medico
2012-12-11 9:01 Zac Medico
2012-11-22 22:06 Mike Frysinger
2012-09-26 20:33 Arfrever Frehtes Taifersar Arahesis
2012-09-14 7:26 Zac Medico
2012-09-14 7:26 Zac Medico
2012-08-15 20:45 Ulrich Mueller
2012-05-12 4:09 Mike Frysinger
2011-07-08 17:15 Zac Medico
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346626606.d184c0f32eba2eec3a8d28ae71be79aa635db147.zmedico@gentoo \
--to=zmedico@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox