public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "André Erdmann" <dywi@mailerd.de>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/R_overlay:master commit in: roverlay/rpackage/
Date: Fri, 29 Jun 2012 22:48:21 +0000 (UTC)	[thread overview]
Message-ID: <1341008830.7c711ba2f85f5a3b4b5479dde81bb6b70a227a49.dywi@gentoo> (raw)

commit:     7c711ba2f85f5a3b4b5479dde81bb6b70a227a49
Author:     André Erdmann <dywi <AT> mailerd <DOT> de>
AuthorDate: Fri Jun 29 22:27:10 2012 +0000
Commit:     André Erdmann <dywi <AT> mailerd <DOT> de>
CommitDate: Fri Jun 29 22:27:10 2012 +0000
URL:        http://git.overlays.gentoo.org/gitweb/?p=proj/R_overlay.git;a=commit;h=7c711ba2

descriptionreader: join lines with '', not ' '

lines are now joined using an empty char, this fixes
reading entries like <<
a (>= 1.0), b
(> 1.5)
>>
fields whose values should be joined using ' ' have to
declare this in the field definition file using the 'joinValues' flag.

	modified:   roverlay/rpackage/descriptionreader.py

---
 roverlay/rpackage/descriptionreader.py |   20 +++++++++++---------
 1 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/roverlay/rpackage/descriptionreader.py b/roverlay/rpackage/descriptionreader.py
index 1f6bd3e..94f36a3 100644
--- a/roverlay/rpackage/descriptionreader.py
+++ b/roverlay/rpackage/descriptionreader.py
@@ -108,21 +108,23 @@ class DescriptionReader ( object ):
 		make_slist = lambda l : tuple ( filter ( None, slist_split ( l, 0 ) ) )
 
 		for field in raw.keys():
-			value_line = ' '.join ( filter ( None, raw [field] ) )
 
-			# join > isList > wsList [... >= join (implicit)]
+			# join (' ') > isList > wsList [... >= join ('', implicit)]
 
 			if field in fields_join:
-				read [field] = value_line
+				read [field] = ' '.join ( filter ( None, raw [field] ) )
 
-			elif field in fields_isList:
-				read [field] = make_list ( value_line )
+			else:
+				value_line = ''.join ( filter ( None, raw [field] ) )
 
-			elif field in fields_wsList:
-				read [field] = make_slist ( value_line )
+				if field in fields_isList:
+					read [field] = make_list ( value_line )
 
-			else:
-				read [field] = value_line
+				elif field in fields_wsList:
+					read [field] = make_slist ( value_line )
+
+				else:
+					read [field] = value_line
 
 
 		return read



             reply	other threads:[~2012-06-29 22:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-29 22:48 André Erdmann [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-02-16  1:35 [gentoo-commits] proj/R_overlay:master commit in: roverlay/rpackage/ Benda XU
2013-08-21 13:51 André Erdmann
2013-08-21 13:51 André Erdmann
2013-08-20 21:46 André Erdmann
2013-07-25 13:28 André Erdmann
2013-07-25 13:25 André Erdmann
2013-07-25  8:47 André Erdmann
2013-07-25  8:47 André Erdmann
2013-07-23 18:34 [gentoo-commits] proj/R_overlay:gsoc13/next " André Erdmann
2013-07-23 18:34 ` [gentoo-commits] proj/R_overlay:master " André Erdmann
2013-07-11 16:29 André Erdmann
2013-04-25 16:44 André Erdmann
2013-02-09 20:45 André Erdmann
2012-08-07  8:50 André Erdmann
2012-07-30  8:52 André Erdmann
2012-07-06 22:19 André Erdmann
2012-07-03 17:48 André Erdmann
2012-07-02 16:52 André Erdmann
2012-06-28 15:55 André Erdmann
2012-06-28 15:55 André Erdmann
2012-06-27 14:46 André Erdmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341008830.7c711ba2f85f5a3b4b5479dde81bb6b70a227a49.dywi@gentoo \
    --to=dywi@mailerd.de \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox