From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1RxpTR-0001He-Fb for garchives@archives.gentoo.org; Thu, 16 Feb 2012 00:45:25 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 8E134E0AFB; Thu, 16 Feb 2012 00:39:14 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 42FF4E0B7A for ; Thu, 16 Feb 2012 00:33:47 +0000 (UTC) Received: from hornbill.gentoo.org (hornbill.gentoo.org [94.100.119.163]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id C62861B401C for ; Thu, 16 Feb 2012 00:33:30 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by hornbill.gentoo.org (Postfix) with ESMTP id 83F1EE5400 for ; Thu, 16 Feb 2012 00:33:29 +0000 (UTC) From: "Zac Medico" To: gentoo-commits@lists.gentoo.org Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Zac Medico" Message-ID: <1329352390.46107423f4a039af6528d14cb86123a05a67f85f.zmedico@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: pym/portage/dbapi/, pym/_emerge/ X-VCS-Repository: proj/portage X-VCS-Files: pym/_emerge/EbuildFetcher.py pym/portage/dbapi/_MergeProcess.py X-VCS-Directories: pym/portage/dbapi/ pym/_emerge/ X-VCS-Committer: zmedico X-VCS-Committer-Name: Zac Medico X-VCS-Revision: 46107423f4a039af6528d14cb86123a05a67f85f X-VCS-Branch: master Date: Thu, 16 Feb 2012 00:33:29 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: quoted-printable X-Archives-Salt: af00a145-3912-4414-98a7-3e6eddce8574 X-Archives-Hash: 09239b999cbcb954190b1deea62192ac commit: 46107423f4a039af6528d14cb86123a05a67f85f Author: Zac Medico gentoo org> AuthorDate: Thu Feb 16 00:33:10 2012 +0000 Commit: Zac Medico gentoo org> CommitDate: Thu Feb 16 00:33:10 2012 +0000 URL: http://git.overlays.gentoo.org/gitweb/?p=3Dproj/portage.git;a= =3Dcommit;h=3D46107423 Comment about _setup_pipes / PyPy GC interaction. --- pym/_emerge/EbuildFetcher.py | 6 +++++- pym/portage/dbapi/_MergeProcess.py | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/pym/_emerge/EbuildFetcher.py b/pym/_emerge/EbuildFetcher.py index c0175b3..f6dab54 100644 --- a/pym/_emerge/EbuildFetcher.py +++ b/pym/_emerge/EbuildFetcher.py @@ -171,7 +171,11 @@ class EbuildFetcher(SpawnProcess): return [pid] =20 # TODO: Find out why PyPy 1.8 with close_fds=3DTrue triggers - # "[Errno 9] Bad file descriptor" in subprocesses. + # "[Errno 9] Bad file descriptor" in subprocesses. It could + # be due to garbage collection of file objects that were not + # closed before going out of scope, since PyPy's garbage + # collector does not support the refcounting semantics that + # CPython does. close_fds =3D platform.python_implementation() !=3D 'PyPy' portage.process._setup_pipes(fd_pipes, close_fds=3Dclose_fds) =20 diff --git a/pym/portage/dbapi/_MergeProcess.py b/pym/portage/dbapi/_Merg= eProcess.py index 21d43dd..9a185b4 100644 --- a/pym/portage/dbapi/_MergeProcess.py +++ b/pym/portage/dbapi/_MergeProcess.py @@ -157,7 +157,11 @@ class MergeProcess(SpawnProcess): os.close(elog_reader_fd) =20 # TODO: Find out why PyPy 1.8 with close_fds=3DTrue triggers - # "[Errno 9] Bad file descriptor" in subprocesses. + # "[Errno 9] Bad file descriptor" in subprocesses. It could + # be due to garbage collection of file objects that were not + # closed before going out of scope, since PyPy's garbage + # collector does not support the refcounting semantics that + # CPython does. close_fds =3D platform.python_implementation() !=3D 'PyPy' portage.process._setup_pipes(fd_pipes, close_fds=3Dclose_fds) =20