From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Qqg3M-0000lW-Mc for garchives@archives.gentoo.org; Tue, 09 Aug 2011 06:44:40 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 21E4321C1FD; Tue, 9 Aug 2011 06:44:33 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id E20EE21C1FD for ; Tue, 9 Aug 2011 06:44:32 +0000 (UTC) Received: from pelican.gentoo.org (unknown [66.219.59.40]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 494F21B4036 for ; Tue, 9 Aug 2011 06:44:32 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by pelican.gentoo.org (Postfix) with ESMTP id 4870A80040 for ; Tue, 9 Aug 2011 06:44:31 +0000 (UTC) From: "Zac Medico" To: gentoo-commits@lists.gentoo.org Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Zac Medico" Message-ID: <022e09dd6ddd8372a9ec2ef2284b7cb174e6e6b2.zmedico@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: pym/repoman/ X-VCS-Repository: proj/portage X-VCS-Files: pym/repoman/checks.py X-VCS-Directories: pym/repoman/ X-VCS-Committer: zmedico X-VCS-Committer-Name: Zac Medico X-VCS-Revision: 022e09dd6ddd8372a9ec2ef2284b7cb174e6e6b2 Date: Tue, 9 Aug 2011 06:44:31 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: quoted-printable X-Archives-Salt: X-Archives-Hash: d8689c08787944632532f2f07d15f4eb commit: 022e09dd6ddd8372a9ec2ef2284b7cb174e6e6b2 Author: Zac Medico gentoo org> AuthorDate: Tue Aug 9 06:44:17 2011 +0000 Commit: Zac Medico gentoo org> CommitDate: Tue Aug 9 06:44:17 2011 +0000 URL: http://git.overlays.gentoo.org/gitweb/?p=3Dproj/portage.git;a= =3Dcommit;h=3D022e09dd repoman: check more helper calls for $D, $ED... This adds docinto, docompress, fowners and fperms to the variable.usedwithhelpers check. Notably absent is dosed since that supports mixed input. This will fix bug #377303. --- pym/repoman/checks.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py index e7472df..bff4b1f 100644 --- a/pym/repoman/checks.py +++ b/pym/repoman/checks.py @@ -341,7 +341,7 @@ class NoOffsetWithHelpers(LineCheck): repoman_check_name =3D 'variable.usedwithhelpers' # Ignore matches in quoted strings like this: # elog "installed into ${ROOT}usr/share/php5/apc/." - re =3D re.compile(r'^[^#"\']*\b(dodir|dohard|exeinto|insinto|into)\s+"?= \$\{?(D|ROOT|ED|EROOT|EPREFIX)\b.*') + re =3D re.compile(r'^[^#"\']*\b(docinto|docompress|dodir|dohard|exeinto= |fowners|fperms|insinto|into)\s+"?\$\{?(D|ROOT|ED|EROOT|EPREFIX)\b.*') error =3D errors.NO_OFFSET_WITH_HELPERS =20 class ImplicitRuntimeDeps(LineCheck):