From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id DCCD515808D for ; Thu, 21 Apr 2022 21:02:05 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id A88CFE081A; Thu, 21 Apr 2022 21:02:04 +0000 (UTC) Received: from rs234.mailgun.us (rs234.mailgun.us [209.61.151.234]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 01E07E081A for ; Thu, 21 Apr 2022 21:02:03 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=0xdc.io; q=dns/txt; s=smtp; t=1650574923; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Subject: To: To: From: From: Date: Sender: Sender; bh=F2rHWq/7dPhNYNtXyRa8zYvwmnE7wYRyeWWw+Cmyd0I=; b=h+Y4IIMmKI0KcDMZ9QTgJWYteRGmlD6iZTjMn3t6xrChE78AAUJmZ8CwilbvVrE3OhuLQNWp OzqauegR7Wx07rbTodVLo4UmOY78jOI8O9V/i7cmucUDNIV8cWId2SM5do2MM/4kK/lTdrYO Eu+WH2rd0PIscSSn+sXgDAA941Y= X-Mailgun-Sending-Ip: 209.61.151.234 X-Mailgun-Sid: WyJiZmIxMyIsICJnZW50b28tY2F0YWx5c3RAbGlzdHMuZ2VudG9vLm9yZyIsICJmNjc0NGUiXQ== Received: from mail.0xdc.io (mail.0xdc.io [54.37.0.172]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 6261c64a3aaac6e56c505539 (version=TLS1.3, cipher=TLS_AES_128_GCM_SHA256); Thu, 21 Apr 2022 21:02:02 GMT Sender: gentoo.catalyst@0xdc.io Received: from pulsar (5.b.0.d.c.4.e.f.f.f.1.0.5.8.8.4.0.a.4.7.9.0.c.0.0.b.8.0.1.0.0.2.ip6.arpa [IPv6:2001:8b0:c09:74a0:4885:1ff:fe4c:d0b5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.0xdc.io (Postfix) with ESMTPSA id CB6A5102418 for ; Thu, 21 Apr 2022 21:03:51 +0000 (UTC) Date: Thu, 21 Apr 2022 21:01:58 +0000 From: Daniel Cordero To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH 4/4] stage4/groups: improve log message Message-ID: References: <20220421070826.92638-1-gentoo.catalyst@0xdc.io> <20220421070826.92638-4-gentoo.catalyst@0xdc.io> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220421070826.92638-4-gentoo.catalyst@0xdc.io> X-Archives-Salt: 38b28c2a-0626-45ce-bfc6-3c7eaffd0ce7 X-Archives-Hash: 87cf2499b6afc24edaed344cea243929 On Thu, Apr 21, 2022 at 07:08:26AM +0000, Daniel Cordero wrote: > When creating a user with no additional groups, don't print a misleading message > saying the user will be created with an equals sign in the username. > --- > catalyst/base/stagebase.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/catalyst/base/stagebase.py b/catalyst/base/stagebase.py > index d4875491..9814ebcc 100644 > --- a/catalyst/base/stagebase.py > +++ b/catalyst/base/stagebase.py > @@ -947,7 +947,7 @@ class StageBase(TargetBase, ClearBase, GenBase): > uacmd = ["useradd", "-R", self.settings['chroot_path'], "-m", x] > if grp != '': > uacmd = ["useradd", "-R", self.settings['chroot_path'], "-m", "-G", grp, usr] > - log.notice("Creating user: '%s'", f"{usr}={grp}") > + log.notice("Creating user: '%s' in group(s): %s", usr, grp) Ah, this patch is wrong as I appear to have mixed up % and .format() syntaxes. > cmd(uacmd, env=self.env) > > def ssh_public_keys(self): > -- > 2.35.1 > >