Re: [gentoo-catalyst] [PATCH 4/4] stage4/groups: improve log message

[Daniel Cordero <gentoo.catalyst@0xdc.io>]

On Thu, Apr 21, 2022 at 07:08:26AM +0000, Daniel Cordero wrote:
> When creating a user with no additional groups, don't print a misleading message
> saying the user will be created with an equals sign in the username.
> ---
>  catalyst/base/stagebase.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/catalyst/base/stagebase.py b/catalyst/base/stagebase.py
> index d4875491..9814ebcc 100644
> --- a/catalyst/base/stagebase.py
> +++ b/catalyst/base/stagebase.py
> @@ -947,7 +947,7 @@ class StageBase(TargetBase, ClearBase, GenBase):
>              uacmd = ["useradd", "-R", self.settings['chroot_path'], "-m", x]
>              if grp != '':
>                  uacmd = ["useradd", "-R", self.settings['chroot_path'], "-m", "-G", grp, usr]
> -            log.notice("Creating user: '%s'", f"{usr}={grp}")
> +            log.notice("Creating user: '%s' in group(s): %s", usr, grp)

Ah, this patch is wrong as I appear to have mixed up % and .format()
syntaxes.

>              cmd(uacmd, env=self.env)
>  
>      def ssh_public_keys(self):
> -- 
> 2.35.1
> 
>