From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 18BE11388BF for ; Thu, 7 Jan 2016 02:35:59 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 4A23DE07E6; Thu, 7 Jan 2016 02:35:57 +0000 (UTC) Received: from mail-lf0-f52.google.com (mail-lf0-f52.google.com [209.85.215.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id AAFB7E07E6 for ; Thu, 7 Jan 2016 02:35:56 +0000 (UTC) Received: by mail-lf0-f52.google.com with SMTP id z124so319096573lfa.3 for ; Wed, 06 Jan 2016 18:35:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; bh=/gCAS2b9dLsDKD7/G2fte88HQQPG7Hnu1Xqo3NrjH/4=; b=T82opXdu0csbC3OfeKsHwkoa468List5lGWfoGj5KXYXxVDXojP4vDfJdrGl3N+Lvh DF7D5dhEAjVssCA9XJ9I5/vlZya+WwNOZLLw47ms6wSAX2BSAHXfv65M26vvcmT8vTwL E6kkYgoPiqetPlukjCT4rABWjz4UcyvOEUoDiuGuEet/y8oHleJGC8sKF5D0wEqrPrcY c8NWeFIlScnd7U+bZpIoZawT+XdgyrMdh0Dssznk1irtun/jzvsmADHdTkiZDHF+Q6Ew mIDXbB05HVbMzsHz2HvJoHf49X1pLHlXx8fYTVwcDLWi91bfMewC38uFnhAkNrfwMOik v7tA== Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 X-Received: by 10.25.90.83 with SMTP id o80mr1319405lfb.23.1452134155268; Wed, 06 Jan 2016 18:35:55 -0800 (PST) Received: by 10.25.28.15 with HTTP; Wed, 6 Jan 2016 18:35:55 -0800 (PST) In-Reply-To: <20160105233047.GP25548@vapier.lan> References: <1450284052-13005-1-git-send-email-kevin.zhaoshuai@gmail.com> <1450284067-13049-1-git-send-email-kevin.zhaoshuai@gmail.com> <20160105233047.GP25548@vapier.lan> Date: Thu, 7 Jan 2016 10:35:55 +0800 Message-ID: Subject: Re: [gentoo-catalyst][PATCH v1 2/3] Modify the create iso parameter of ppc64le and power8 From: Kevin Zhao To: gentoo-catalyst@lists.gentoo.org, Zhao Kevin Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: 84409f02-2361-48d9-a4f8-8ec7b4254daa X-Archives-Hash: 3e763c1b59701e8bc3286249e0da5e28 2016-01-06 7:30 GMT+08:00 Mike Frysinger : > On 16 Dec 2015 11:41, Kevin Zhao wrote: >> - run_mkisofs -r -U -chrp-boot -netatalk -hfs -probe -map "$= {clst_target_path}"/boot/map.hfs -part -no-desktop -hfs-volid "${clst_iso_v= olume_id}" -hfs-bless "${clst_target_path}"/boot -hide-hfs "zisofs" -hide-h= fs "stages" -hide-hfs "distfiles" -hide-hfs "snapshots" -J ${mkisofs_zisofs= _opts} -V "${clst_iso_volume_id}" -o "${1}" "${clst_target_path}"/ >> + if [ "${clst_subarch}" =3D=3D "ppc64le" ]||[ "${clst_subar= ch}" =3D=3D "power8" ] > > please put spaces around the || operator, and use =3D instead of =3D=3D > > isn't this power8 specific ? so do you really need to look at ppc64le ? Thanks for the comment Mike. It is not the power8 specific, all the ppc64le arch(including power7le and power8le)will use the new command > >> + then >> + run_mkisofs -v -r -T -U -l -cache-inodes -chrp-boo= t -V "${clst_iso_volume_id}" -o "${1}" "${clst_target_path}" >> + else >> + run_mkisofs -r -U -chrp-boot -netatalk -hfs -probe= -map "${clst_target_path}"/boot/map.hfs -part -no-desktop -hfs-volid "${cl= st_iso_volume_id}" -hfs-bless "${clst_target_path}"/boot -hide-hfs "zisofs"= -hide-hfs "stages" -hide-hfs "distfiles" -hide-hfs "snapshots" -J ${mkisof= s_zisofs_opts} -V "${clst_iso_volume_id}" -o "${1}" "${clst_target_path}"/ >> + fi > > i know the existing code is ugly, but please fix that here. rather than > duplicate the huge command line, factor out the common bits. something > like: > flags=3D( -r -U ) > if [ "${clst_subarch}" =3D "power8" ] > then > flags+=3D( > -v -T -l -cache-inodes -chrp-boot > ) > else > flags+=3D( > ... > ) > fi > run_mkisofs "${flags[@]}" \ > -J ${mkisofs_zisofs_opts} > -V "${clst_iso_volume_id}" -o "${1}" "${clst_target_path}= " > > also, it seems like some of the flags you dropped for power8 should stay = there. > -mike OK I will fix it here.Thanks~I will send the modifying patches again after tweaking.