From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 5B0F81382C5 for ; Thu, 21 May 2020 20:41:37 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 53F48E0883; Thu, 21 May 2020 20:41:36 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 34942E0883 for ; Thu, 21 May 2020 20:41:36 +0000 (UTC) Received: by mail-ej1-f46.google.com with SMTP id x20so10429482ejb.11 for ; Thu, 21 May 2020 13:41:34 -0700 (PDT) X-Gm-Message-State: AOAM530vr5Xta56h2dJKHRlZNIHroEbx4N3hWcH2BMZua3VXuejAEvZ+ g31OaLYWY6lrxTdbaeruFfTKqDlX8fJ4xZXopds= X-Google-Smtp-Source: ABdhPJyhzMJDfyaMVcjX8Yq8h32HOuzMdNEgidgDw8qLV2qoZJvSySEDUG0tkWtFkl0HWajSrsWuGhsFDose+Zfl4R8= X-Received: by 2002:a17:906:7fd7:: with SMTP id r23mr5132080ejs.386.1590093691344; Thu, 21 May 2020 13:41:31 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 References: <20200521173248.2297765-1-gentoo.catalyst@xxoo.ws> In-Reply-To: <20200521173248.2297765-1-gentoo.catalyst@xxoo.ws> From: Matt Turner Date: Thu, 21 May 2020 13:41:18 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [gentoo-catalyst] [PATCH 1/5] embedded: remove actions that are broken by default To: gentoo-catalyst@lists.gentoo.org Content-Type: text/plain; charset="UTF-8" X-Archives-Salt: 6025c4a4-aeec-4486-931d-a6ad4e9ae400 X-Archives-Hash: 1e4114dd52611d4b1e8124c89037f5d4 On Thu, May 21, 2020 at 10:34 AM Daniel Cordero wrote: > > From: Daniel Cordero > > dir_setup() doesn't exist, bootloader() exists but requires specific > tools to be installed in the seed stage and doesn't check that they are, > causing the build to fail. > --- > If I have misconstrued the purpose of bootloader, then documentation > needs to be written. I don't actually see any documentation about > catalyst/targets/embedded.py | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/catalyst/targets/embedded.py b/catalyst/targets/embedded.py > index aa23f5b3..1b4ad9d6 100644 > --- a/catalyst/targets/embedded.py > +++ b/catalyst/targets/embedded.py > @@ -41,7 +41,6 @@ class embedded(StageBase): > > def set_action_sequence(self): > self.settings['action_sequence'] = [ > - "dir_setup", Nice. This function was removed in 2005, so the embedded target has been broken ever since. That certainly answers my question as to whether anyone uses it. Fixes: 1dafb5fa06d2 (Add locking support. ...) So, you must use the embedded target. Could you tell me how you use it, for what device, etc? > "unpack", > "config_profile_link", > "setup_confdir", > @@ -51,7 +50,6 @@ class embedded(StageBase): > "setup_environment", > "build_kernel", > "build_packages", > - "bootloader", It's not obvious to me what specific tools this requires to be installed in the seed stage. Presumably you're referring to this? cmd([self.settings['controller_file'], 'bootloader', self.settings['target_path'].rstrip('/')] which eventually runs bootloader-setup.sh. I'd assume it's generally sensible to install a bootloader in the embedded target, and I don't think we have mechanism for customizing the action_sequence, so if we remove bootloader from the list then I think the python bootloader() function is just dead code, isn't it? I doubt that's the end result we want.