From: Matt Turner <mattst88@gentoo.org>
To: gentoo-catalyst@lists.gentoo.org
Subject: Re: [gentoo-catalyst] [PATCH 3/3] Build ISO with Joliet directory information
Date: Fri, 23 Oct 2020 10:16:33 -0700 [thread overview]
Message-ID: <CAEdQ38Hpty77a804rPSd4FbginJuZ_k4fLo8FrA6dFY_GFvbjw@mail.gmail.com> (raw)
In-Reply-To: <20201023170059.GB71925@dysnomia.localdomain>
On Fri, Oct 23, 2020 at 10:01 AM Daniel Cordero <gentoo.catalyst@xxoo.ws> wrote:
>
> On Fri, Oct 23, 2020 at 09:25:29AM -0700, Matt Turner wrote:
> > On Fri, Oct 23, 2020 at 2:19 AM Daniel Cordero <gentoo.catalyst@xxoo.ws> wrote:
> > >
> > > From: Daniel Cordero <catalyst@0xdc.io>
> > >
> > > Previous syslinux based CDs had this information.
> > > Necessary for direct kernel booting with virt-install --location.
> > >
> > > Fixes: 0a27a7a39a "targets: Use GRUB for BIOS boot"
> > >
> > > Signed-off-by: Daniel Cordero <catalyst@0xdc.io>
> > > ---
> > > targets/support/create-iso.sh | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/targets/support/create-iso.sh b/targets/support/create-iso.sh
> > > index 9b1c7185..b11b046f 100755
> > > --- a/targets/support/create-iso.sh
> > > +++ b/targets/support/create-iso.sh
> > > @@ -192,6 +192,7 @@ case ${clst_hostarch} in
> > > isoroot_checksum
> > >
> > > case ${clst_hostarch} in
> > > + amd64|x86) extra_opts="-joliet" ;;
> >
> > Is there any reason to limit this to amd64/x86?
> >
>
> My concern is that the other arches may not have had this information on
> their ISOs. I do not know if those arches might not like it.
Oh, I see: this flag is passed through grub-mkrescue to mkisofs. I
guess this is an alias for the -J flag to mkisofs? Strange that I
don't see it documented in either mkisofs(8) or grub-mkrescue(1). It
looks like we're passing -J to mkisofs/xorriso on alpha and hppa, so
my feeling is that we should just use it on all platforms. I'm happy
to adjust the patch when I commit it.
next prev parent reply other threads:[~2020-10-23 17:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 9:18 [gentoo-catalyst] [PATCH 1/3] Re-allow the use of mksquashfs to pack the livecd contents Daniel Cordero
2020-10-23 9:18 ` [gentoo-catalyst] [PATCH 2/3] Update requirements for amd64/x86 ISO creation Daniel Cordero
2020-10-23 16:24 ` Matt Turner
2020-10-25 21:20 ` Daniel Cordero
2020-10-26 13:25 ` Thomas Schmitt
2020-10-23 9:18 ` [gentoo-catalyst] [PATCH 3/3] Build ISO with Joliet directory information Daniel Cordero
2020-10-23 16:25 ` Matt Turner
2020-10-23 17:00 ` Daniel Cordero
2020-10-23 17:16 ` Matt Turner [this message]
2020-10-23 16:22 ` [gentoo-catalyst] [PATCH 1/3] Re-allow the use of mksquashfs to pack the livecd contents Matt Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEdQ38Hpty77a804rPSd4FbginJuZ_k4fLo8FrA6dFY_GFvbjw@mail.gmail.com \
--to=mattst88@gentoo.org \
--cc=gentoo-catalyst@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox