From: Matt Turner <mattst88@gentoo.org>
To: gentoo-catalyst@lists.gentoo.org
Subject: Re: [gentoo-catalyst] [PATCH] bootloader-setup.sh: remove obsolete cmdline args
Date: Thu, 30 Mar 2023 08:56:27 -0400 [thread overview]
Message-ID: <CAEdQ38HL6b+97u-H6wkcGJ=jRhp_EhEpLn1njyq=16Ok4XDP5Q@mail.gmail.com> (raw)
In-Reply-To: <20230329201418.2976304-1-bkohler@gentoo.org>
On Wed, Mar 29, 2023 at 4:14 PM Ben Kohler <bkohler@gentoo.org> wrote:
>
> These haven't been needed since kernel 2.4 days, as far as I know.
>
> Signed-off-by: Ben Kohler <bkohler@gentoo.org>
> ---
> targets/support/bootloader-setup.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/targets/support/bootloader-setup.sh b/targets/support/bootloader-setup.sh
> index 065f2bb5..32d86028 100755
> --- a/targets/support/bootloader-setup.sh
> +++ b/targets/support/bootloader-setup.sh
> @@ -53,7 +53,7 @@ memtest_grub() {
> fi
> }
>
> -default_append_line=(root=/dev/ram0 init=/linuxrc ${cmdline_opts[@]} cdroot)
> +default_append_line=(${cmdline_opts[@]} cdroot)
>
> case ${clst_hostarch} in
> alpha)
> --
> 2.40.0
Looks like we add 'root=/dev/ram0 init=/linuxrc' a few lines below in
the alpha-specific path as well. I wonder if we should drop it from
there too?
Otherwise, looks good to me.
next prev parent reply other threads:[~2023-03-30 12:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 20:14 [gentoo-catalyst] [PATCH] bootloader-setup.sh: remove obsolete cmdline args Ben Kohler
2023-03-30 12:56 ` Matt Turner [this message]
2023-03-30 13:17 ` Ben Kohler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEdQ38HL6b+97u-H6wkcGJ=jRhp_EhEpLn1njyq=16Ok4XDP5Q@mail.gmail.com' \
--to=mattst88@gentoo.org \
--cc=gentoo-catalyst@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox