From: Matt Turner <mattst88@gentoo.org>
To: gentoo-catalyst@lists.gentoo.org
Cc: Georgy Yakovlev <gyakovlev@gentoo.org>
Subject: Re: [gentoo-catalyst] [PATCH 1/2] targets/support/create-iso.sh: add arm64 support
Date: Sun, 25 Jul 2021 22:14:55 -0700 [thread overview]
Message-ID: <CAEdQ38HFrCYDE3bTZkP6Qwtg9OCUbJ9TZaOH8OWF4DLEMyYpiw@mail.gmail.com> (raw)
In-Reply-To: <20210725235113.1256043-1-gyakovlev@gentoo.org>
On Sun, Jul 25, 2021 at 4:51 PM Georgy Yakovlev <gyakovlev@gentoo.org> wrote:
>
> Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
> ---
> targets/support/create-iso.sh | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/targets/support/create-iso.sh b/targets/support/create-iso.sh
> index 70684f78..729f5c15 100755
> --- a/targets/support/create-iso.sh
> +++ b/targets/support/create-iso.sh
> @@ -18,7 +18,7 @@ case ${clst_hostarch} in
> cdmaker="grub-mkrescue"
> cdmakerpkg="dev-libs/libisoburn and sys-boot/grub:2"
> ;;
> - amd64|ia64|x86)
> + amd64|arm64|ia64|x86)
> cdmaker="grub-mkrescue"
> # grub-mkrescue requires:
> # xorriso from libisoburn
> @@ -52,6 +52,9 @@ then
> arm)
> clst_iso_volume_id="Gentoo Linux - ARM"
> ;;
> + arm64)
> + clst_iso_volume_id="Gentoo Linux - ARM64"
> + ;;
> hppa)
> clst_iso_volume_id="Gentoo Linux - HPPA"
> ;;
> @@ -188,7 +191,7 @@ case ${clst_hostarch} in
> # o= output image (burnable to CD; readable by fdisk)
> /usr/bin/sgibootcd c=${cfg} o=${clst_iso}
> ;;
> - amd64|ia64|ppc*|powerpc*|sparc*|x86)
> + amd64|arm64|ia64|ppc*|powerpc*|sparc*|x86)
> isoroot_checksum
>
> extra_opts=("-joliet")
> --
> 2.32.0
Looks good. I'd just squash "[PATCH]
targets/support/bootloader-setup.sh: add arm64 support" into this one
and change the commit prefix to "targets: ".
prev parent reply other threads:[~2021-07-26 5:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-25 5:16 [gentoo-catalyst] [PATCH] targets/support/create-iso.sh: use mkrescue on arm64 Georgy Yakovlev
2021-07-25 23:51 ` [gentoo-catalyst] [PATCH 1/2] targets/support/create-iso.sh: add arm64 support Georgy Yakovlev
2021-07-25 23:51 ` [gentoo-catalyst] [PATCH 2/2] targets/support/create-iso.sh: use app-cdr/cdrtools instead of virtual Georgy Yakovlev
2021-07-26 2:27 ` [gentoo-catalyst] [PATCH] targets/support/bootloader-setup.sh: add arm64 support Georgy Yakovlev
2021-07-26 5:14 ` Matt Turner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEdQ38HFrCYDE3bTZkP6Qwtg9OCUbJ9TZaOH8OWF4DLEMyYpiw@mail.gmail.com \
--to=mattst88@gentoo.org \
--cc=gentoo-catalyst@lists.gentoo.org \
--cc=gyakovlev@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox