From: Matt Turner <mattst88@gentoo.org>
To: Daniel Cordero <gentoo.catalyst@xxoo.ws>
Cc: gentoo-catalyst@lists.gentoo.org
Subject: Re: [gentoo-catalyst] [PATCH 11/11] catalyst: Remove update_seed spec option
Date: Tue, 19 Jan 2021 09:58:15 -0500 [thread overview]
Message-ID: <CAEdQ38G7F2PJbrgjKX9DkMNB2En5OFzyTmwUP+2feW3kDhqspQ@mail.gmail.com> (raw)
In-Reply-To: <YAa8NfConRpud63P@dysnomia.localdomain>
On Tue, Jan 19, 2021 at 6:04 AM Daniel Cordero <gentoo.catalyst@xxoo.ws> wrote:
> On Mon, Jan 18, 2021 at 03:21:52PM -0500, Matt Turner wrote:
> > There should be no need for custom updates, and if there are exceptional
> > circumstances the new --enter-chroot option can be used.
> >
>
> There is still a need, and if I'm reading these patches right,
> --enter-chroot would not satisfy that need.
>
> enter-chroot is interactive, and, depending on hardware speed, the time
> between kicking off the catalyst run and when the chroot shell is
> invoked may be some time for a human operator to monitor.
>
> It also adds non-deterministic, un-reproducible behaviour to a build.
> Having it in the spec file at least means it is included in a build
> artifact.
Can you think of a case where update_seed would be needed? I tried,
and couldn't think of anything, but I might not be imaginative enough.
My thinking is that with @changed-subslots, there's essentially no
need to update the seed stage further. But there have been some
exceptional cases that don't really fit update_seed (e.g., things that
cannot be fixed with emerge ...).
next prev parent reply other threads:[~2021-01-19 14:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 20:21 [gentoo-catalyst] [PATCH 01/11] targets: Remove unused 'enter' command Matt Turner
2021-01-18 20:21 ` [gentoo-catalyst] [PATCH 02/11] targets: Remove some obvious comments Matt Turner
2021-01-18 20:21 ` [gentoo-catalyst] [PATCH 03/11] targets: Update seed stage's sys-apps/portage Matt Turner
2021-01-18 20:21 ` [gentoo-catalyst] [PATCH 04/11] targets: Update BINPKG_COMPRESS to new zstd default Matt Turner
2021-01-18 20:21 ` [gentoo-catalyst] [PATCH 05/11] targets: Update the @changed-subslot set by default Matt Turner
2021-01-18 20:21 ` [gentoo-catalyst] [PATCH 06/11] catalyst: Store references to functions Matt Turner
2021-01-18 20:21 ` [gentoo-catalyst] [PATCH 07/11] catalyst: Call config_profile_link for all targets Matt Turner
2021-02-25 13:09 ` [gentoo-catalyst] [PATCH] Fix specifying target_profiles in repo_name:path format Daniel Cordero
2021-02-27 18:52 ` [gentoo-catalyst] " Matt Turner
2021-02-27 23:31 ` Felix Bier
2021-01-18 20:21 ` [gentoo-catalyst] [PATCH 08/11] catalyst: Deduplicate prepare_sequence assignments Matt Turner
2021-01-18 20:21 ` [gentoo-catalyst] [PATCH 09/11] catalyst: Deduplicate the common build_sequence steps Matt Turner
2021-01-18 20:21 ` [gentoo-catalyst] [PATCH 10/11] catalyst: Add option to enter the chroot before building Matt Turner
2021-01-18 20:21 ` [gentoo-catalyst] [PATCH 11/11] catalyst: Remove update_seed spec option Matt Turner
2021-01-19 11:02 ` Daniel Cordero
2021-01-19 14:58 ` Matt Turner [this message]
2021-01-21 5:12 ` Matt Turner
2021-01-21 10:20 ` Daniel Cordero
2021-01-22 0:04 ` Matt Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEdQ38G7F2PJbrgjKX9DkMNB2En5OFzyTmwUP+2feW3kDhqspQ@mail.gmail.com \
--to=mattst88@gentoo.org \
--cc=gentoo-catalyst@lists.gentoo.org \
--cc=gentoo.catalyst@xxoo.ws \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox