From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 70B661382C5 for ; Fri, 22 May 2020 00:23:01 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 3926FE089A; Fri, 22 May 2020 00:22:59 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id C8984E089A for ; Fri, 22 May 2020 00:22:58 +0000 (UTC) Received: by mail-ed1-f48.google.com with SMTP id l5so8018880edn.7 for ; Thu, 21 May 2020 17:22:57 -0700 (PDT) X-Gm-Message-State: AOAM532xcbKj5+P4e6LNvdaYadCkw8eRHoEtTwy7wUZaCSQbw5s0WgPx x1QIUZOn1k1R5Pj79DDhmtfdXwGxHRXiXjRwTEo= X-Google-Smtp-Source: ABdhPJwK7kF4P5YrKAXJ2mYOujFi+83cKGVP6cfx9aok+fXNNwaCHguIaFllPO+csCj1HfEELeTuHi6oSS/DhgbplCk= X-Received: by 2002:a50:9e2c:: with SMTP id z41mr1030014ede.193.1590106974456; Thu, 21 May 2020 17:22:54 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 References: <20200521173248.2297765-1-gentoo.catalyst@xxoo.ws> <20200521150850.5743f856@storm> In-Reply-To: <20200521150850.5743f856@storm> From: Matt Turner Date: Thu, 21 May 2020 17:22:42 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [gentoo-catalyst] [PATCH 1/5] embedded: remove actions that are broken by default To: gentoo-catalyst@lists.gentoo.org Content-Type: text/plain; charset="UTF-8" X-Archives-Salt: fd3f88d2-76fc-40d5-a313-64c17c821707 X-Archives-Hash: 768ffc1f17bf3757eb39458bea7f4220 On Thu, May 21, 2020 at 3:08 PM Brian Dolbec wrote: > > On Thu, 21 May 2020 13:41:18 -0700 > Matt Turner wrote: > > > On Thu, May 21, 2020 at 10:34 AM Daniel Cordero > > wrote: > > > > > > From: Daniel Cordero > > > > > > dir_setup() doesn't exist, bootloader() exists but requires specific > > > tools to be installed in the seed stage and doesn't check that they > > > are, causing the build to fail. > > > --- > > > If I have misconstrued the purpose of bootloader, then documentation > > > needs to be written. > > > > I don't actually see any documentation about > > > catalyst/targets/embedded.py | 2 -- > > > 1 file changed, 2 deletions(-) > > > > > > diff --git a/catalyst/targets/embedded.py > > > b/catalyst/targets/embedded.py index aa23f5b3..1b4ad9d6 100644 > > > --- a/catalyst/targets/embedded.py > > > +++ b/catalyst/targets/embedded.py > > > @@ -41,7 +41,6 @@ class embedded(StageBase): > > > > > > def set_action_sequence(self): > > > self.settings['action_sequence'] = [ > > > - "dir_setup", > > > > Nice. This function was removed in 2005, so the embedded target has > > been broken ever since. That certainly answers my question as to > > whether anyone uses it. > > > > Fixes: 1dafb5fa06d2 (Add locking support. ...) > > > > So, you must use the embedded target. Could you tell me how you use > > it, for what device, etc? > > > > > "unpack", > > > "config_profile_link", > > > "setup_confdir", > > > @@ -51,7 +50,6 @@ class embedded(StageBase): > > > "setup_environment", > > > "build_kernel", > > > "build_packages", > > > - "bootloader", > > > > It's not obvious to me what specific tools this requires to be > > installed in the seed stage. Presumably you're referring to this? > > > > cmd([self.settings['controller_file'], 'bootloader', > > self.settings['target_path'].rstrip('/')] > > > > which eventually runs bootloader-setup.sh. > > > > I'd assume it's generally sensible to install a bootloader in the > > embedded target, and I don't think we have mechanism for customizing > > the action_sequence, so if we remove bootloader from the list then I > > think the python bootloader() function is just dead code, isn't it? I > > doubt that's the end result we want. > > > > > No, if you notice, this is removing the bootloader action sequence only > for the embedded target. Each target subclasses stagebase, so can > override what is defined in stagebase as needed. Customizing the > action_sequence is something that pretty much all the targets do. Sorry I misspoke. Yes, bootloader() is called for livecd_stage2 and stage4 as well, so removing it from embedded's action sequence would not make the function dead. I have doubts that we actually want to not run bootloader() for the embedded target though.