From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 7C3771382C5 for ; Sun, 17 May 2020 00:38:39 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 57A96E08AD; Sun, 17 May 2020 00:38:36 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id EA081E08AD for ; Sun, 17 May 2020 00:38:35 +0000 (UTC) Received: by mail-ej1-f48.google.com with SMTP id j21so1023675ejy.1 for ; Sat, 16 May 2020 17:38:34 -0700 (PDT) X-Gm-Message-State: AOAM533eInECuT/VcjsE+raZqfITEGy8Sx+1XEOyaJZD+l7DdK5A/x8e 2WmLHm86C77Sa8thG1HpZmiafNPpvBDl2g5UM1w= X-Google-Smtp-Source: ABdhPJwTwwdH2y4z5/MaJ86NR9EwOOgWzqBoC9XgJNQaRLgjNQOf2f0T4KhUzIzoQK6LFz+2SqGQrKBJ31RYdnZ3hSU= X-Received: by 2002:a17:906:a984:: with SMTP id jr4mr9196191ejb.3.1589675911394; Sat, 16 May 2020 17:38:31 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 References: <20200516232939.2709013-1-mattst88@gentoo.org> In-Reply-To: <20200516232939.2709013-1-mattst88@gentoo.org> From: Matt Turner Date: Sat, 16 May 2020 17:38:19 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: [gentoo-catalyst] Re: [PATCH] targets: Don't delete pyc/pyo files To: gentoo-catalyst@lists.gentoo.org Content-Type: text/plain; charset="UTF-8" X-Archives-Salt: 4a9a2282-b1f9-4f2c-b660-be8833f09ca9 X-Archives-Hash: aebeef8a3260ec7f5b3e1f9c00549785 On Sat, May 16, 2020 at 4:29 PM Matt Turner wrote: > > These files are actually owned by their packages now, and removing them > can break subsequent builds. > > See https://archives.gentoo.org/gentoo-releng-autobuilds/message/a115781f8e7fb4bd5adfb94a7f2e63b4 > > Signed-off-by: Matt Turner > --- > I'm minimally concerned about the potential for increasing the size of > the ISO. I'll report back with numbers. > > targets/livecd-stage1/controller.sh | 4 ---- > targets/livecd-stage2/controller.sh | 2 -- > targets/stage1/preclean-chroot.sh | 2 -- > 3 files changed, 8 deletions(-) > > diff --git a/targets/livecd-stage1/controller.sh b/targets/livecd-stage1/controller.sh > index ced2634e..c4572ff9 100755 > --- a/targets/livecd-stage1/controller.sh > +++ b/targets/livecd-stage1/controller.sh > @@ -13,9 +13,5 @@ case $1 in > ${clst_shdir}/${clst_target}/chroot.sh > echo "${clst_packages}" > ${clst_chroot_path}/tmp/packages.txt > ;; > - > - clean) > - find ${clst_chroot_path}/usr/lib -iname "*.pyc" -exec rm -f {} \; > - ;; > esac > exit $? > diff --git a/targets/livecd-stage2/controller.sh b/targets/livecd-stage2/controller.sh > index 8ee46d7c..0701a26b 100755 > --- a/targets/livecd-stage2/controller.sh > +++ b/targets/livecd-stage2/controller.sh > @@ -85,8 +85,6 @@ case $1 in > then > # Clean out man, info and doc files > rm -rf ${clst_chroot_path}/usr/share/{man,doc,info}/* > - # Zap all .pyc and .pyo files > - find ${clst_chroot_path}/usr/lib* -iname "*.py[co]" -exec rm -f {} \; I think we may want to keep this intact for livecd-stage2. The ISO sizes goes from 286M to 305M. What do other people think?