From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-catalyst+bounces-3649-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id 65FA61382C5
	for <garchives@archives.gentoo.org>; Thu, 21 May 2020 20:45:35 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 8B9B0E0938;
	Thu, 21 May 2020 20:45:34 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id 6D5A4E0938
	for <gentoo-catalyst@lists.gentoo.org>; Thu, 21 May 2020 20:45:34 +0000 (UTC)
Received: by mail-ed1-f43.google.com with SMTP id g9so7660044edw.10
        for <gentoo-catalyst@lists.gentoo.org>; Thu, 21 May 2020 13:45:33 -0700 (PDT)
X-Gm-Message-State: AOAM530jJIMfGM9OFV2RPfJsjxglUsr++W9ZINwdlyNVClbeZwa1BWL2
	DK+We6aeG0D4uUdN3rU6yKaCcsuiDEpSQUnCxg4=
X-Google-Smtp-Source: ABdhPJzN46eawNslak8bWUNxfIFED8ah2JoedBZoLPmqpTp8dFFXGHeQLfykyDMS1HCKYBZac4c2DK7dFrgi0J4tPYY=
X-Received: by 2002:a50:a7e4:: with SMTP id i91mr439347edc.381.1590093930668;
 Thu, 21 May 2020 13:45:30 -0700 (PDT)
Precedence: bulk
List-Post: <mailto:gentoo-catalyst@lists.gentoo.org>
List-Help: <mailto:gentoo-catalyst+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-catalyst+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-catalyst+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-catalyst.gentoo.org>
X-BeenThere: gentoo-catalyst@lists.gentoo.org
Reply-to: gentoo-catalyst@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
MIME-Version: 1.0
References: <20200521173248.2297765-1-gentoo.catalyst@xxoo.ws> <20200521173248.2297765-2-gentoo.catalyst@xxoo.ws>
In-Reply-To: <20200521173248.2297765-2-gentoo.catalyst@xxoo.ws>
From: Matt Turner <mattst88@gentoo.org>
Date: Thu, 21 May 2020 13:45:18 -0700
X-Gmail-Original-Message-ID: <CAEdQ38F1HXuLf1jkt3mpF+6bK4WcSiu-AeHJvaWo6PeW3LbWAg@mail.gmail.com>
Message-ID: <CAEdQ38F1HXuLf1jkt3mpF+6bK4WcSiu-AeHJvaWo6PeW3LbWAg@mail.gmail.com>
Subject: Re: [gentoo-catalyst] [PATCH 2/5] stagebase: allow specfiles to
 define install_mask
To: gentoo-catalyst@lists.gentoo.org
Content-Type: text/plain; charset="UTF-8"
X-Archives-Salt: 40b5b698-6abc-45cd-a808-05cf0462d3b5
X-Archives-Hash: c84c4be99e0f284ca6aec7011d129bfe

On Thu, May 21, 2020 at 10:34 AM Daniel Cordero <gentoo.catalyst@xxoo.ws> wrote:
>
> From: Daniel Cordero <catalyst@0xdc.io>
>
> There is some code that uses this option - set_install_mask() - but it was not
> added to the list of valid specfile options.
>
> The only mention of use is in the embedded target, but it may also be useful
> for other stages.
> ---
> install_mask allows the use of wildcard glob patterns, where */rm
> doesn't.
>
>  catalyst/base/stagebase.py | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/catalyst/base/stagebase.py b/catalyst/base/stagebase.py
> index 651bf4e4..3e8f074e 100644
> --- a/catalyst/base/stagebase.py
> +++ b/catalyst/base/stagebase.py
> @@ -54,6 +54,7 @@ class StageBase(TargetBase, ClearBase, GenBase):
>              "fcflags",
>              "fflags",
>              "hostuse",
> +            "install_mask",
>              "kerncache_path",
>              "ldflags",
>              "makeopts",
> --
> 2.26.2

Nice. I'll add a bit of documentation to the man page when I commit this.