From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 25296138350 for ; Wed, 8 Apr 2020 00:26:01 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 69763E0952; Wed, 8 Apr 2020 00:26:00 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 1DFC0E0952 for ; Wed, 8 Apr 2020 00:26:00 +0000 (UTC) Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mattst88) by smtp.gentoo.org (Postfix) with ESMTPSA id 53F3034F088 for ; Wed, 8 Apr 2020 00:25:59 +0000 (UTC) Received: by mail-ed1-f44.google.com with SMTP id z65so6404519ede.0 for ; Tue, 07 Apr 2020 17:25:59 -0700 (PDT) X-Gm-Message-State: AGi0PubyHF1f07Xgjz5tV8gxLP0RT1h/uKpPHRxV+4xTLwrthv69XZwr AfkmVV+S1Oy/wqkjRHKwwihmUHQrLhErorOKwlA= X-Google-Smtp-Source: APiQypILp7EK8fE0yjvOdaYz6Cmuba2TtJo9T90jEsuTcllKY4CqmTKuadRsAFqZ63GXFBNzFCfgn+JvWmtqE60J9gM= X-Received: by 2002:a17:907:4006:: with SMTP id nj6mr4397325ejb.372.1586305556514; Tue, 07 Apr 2020 17:25:56 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 References: <20200330032644.3086274-1-mattst88@gentoo.org> In-Reply-To: From: Matt Turner Date: Tue, 7 Apr 2020 17:25:44 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [gentoo-catalyst] [PATCH 1/2] targets: Set LANG=C.UTF8 To: Alec Warner Cc: gentoo-catalyst@lists.gentoo.org Content-Type: text/plain; charset="UTF-8" X-Archives-Salt: f1cf33cf-2630-4d4b-b146-6950d6a61e81 X-Archives-Hash: dfd8e70d6ced92fd097ceb00bf455b82 On Tue, Apr 7, 2020 at 2:26 PM Alec Warner wrote: > On Sun, Mar 29, 2020 at 8:26 PM Matt Turner wrote: >> >> Stable glibc now always provides a UTF-8 capable locale, which many >> packages require. Set this as the default LANG. >> >> Running locale-gen in stage1 should also solve bug #536938. >> >> Bug: https://bugs.gentoo.org/536938 >> Bug: https://bugs.gentoo.org/710762 >> Bug: https://bugs.gentoo.org/714906 >> Signed-off-by: Matt Turner >> --- >> targets/stage1/chroot.sh | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/targets/stage1/chroot.sh b/targets/stage1/chroot.sh >> index 0caf49ee..88a36481 100755 >> --- a/targets/stage1/chroot.sh >> +++ b/targets/stage1/chroot.sh >> @@ -57,6 +57,11 @@ make_destpath /tmp/stage1root >> run_merge "--oneshot --nodeps sys-apps/baselayout" >> ${clst_sed} -i "/USE=\"${USE} -build\"/d" ${clst_make_conf} >> >> +for etc in /etc /tmp/stage1root/etc; do >> + echo "LANG=C.UTF8" > ${etc}/env.d/02locale >> +done >> +update_env_settings >> + > > > if /tmp/stage1root is "${clst_root_path}" I think it might behoove you to use it here rather than hard coding it. > Same as below. Thank you. Fixed and pushed (since I realized that USE=compile-locales is actually already unmasked on the latest stable glibc).