From: Matt Turner <mattst88@gentoo.org>
To: Alec Warner <antarus@gentoo.org>
Cc: gentoo-catalyst@lists.gentoo.org
Subject: Re: [gentoo-catalyst] [PATCH 1/2] targets: Set LANG=C.UTF8
Date: Tue, 7 Apr 2020 17:25:44 -0700 [thread overview]
Message-ID: <CAEdQ38Edc2W5JESZXyAjzBq0oqufBCXT0xGEO76mECMnCAg1xw@mail.gmail.com> (raw)
In-Reply-To: <CAAr7Pr_f1pSPKWVhoU7HVPZxw7mYsCoa4jhmDuPLk3rku9uoCg@mail.gmail.com>
On Tue, Apr 7, 2020 at 2:26 PM Alec Warner <antarus@gentoo.org> wrote:
> On Sun, Mar 29, 2020 at 8:26 PM Matt Turner <mattst88@gentoo.org> wrote:
>>
>> Stable glibc now always provides a UTF-8 capable locale, which many
>> packages require. Set this as the default LANG.
>>
>> Running locale-gen in stage1 should also solve bug #536938.
>>
>> Bug: https://bugs.gentoo.org/536938
>> Bug: https://bugs.gentoo.org/710762
>> Bug: https://bugs.gentoo.org/714906
>> Signed-off-by: Matt Turner <mattst88@gentoo.org>
>> ---
>> targets/stage1/chroot.sh | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/targets/stage1/chroot.sh b/targets/stage1/chroot.sh
>> index 0caf49ee..88a36481 100755
>> --- a/targets/stage1/chroot.sh
>> +++ b/targets/stage1/chroot.sh
>> @@ -57,6 +57,11 @@ make_destpath /tmp/stage1root
>> run_merge "--oneshot --nodeps sys-apps/baselayout"
>> ${clst_sed} -i "/USE=\"${USE} -build\"/d" ${clst_make_conf}
>>
>> +for etc in /etc /tmp/stage1root/etc; do
>> + echo "LANG=C.UTF8" > ${etc}/env.d/02locale
>> +done
>> +update_env_settings
>> +
>
>
> if /tmp/stage1root is "${clst_root_path}" I think it might behoove you to use it here rather than hard coding it.
> Same as below.
Thank you. Fixed and pushed (since I realized that USE=compile-locales
is actually already unmasked on the latest stable glibc).
next prev parent reply other threads:[~2020-04-08 0:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 3:26 [gentoo-catalyst] [PATCH 1/2] targets: Set LANG=C.UTF8 Matt Turner
2020-03-30 3:26 ` [gentoo-catalyst] [PATCH 2/2] targets: Reduce locales to C.UTF8 in stage builds Matt Turner
2020-04-07 21:25 ` [gentoo-catalyst] [PATCH 1/2] targets: Set LANG=C.UTF8 Alec Warner
2020-04-08 0:25 ` Matt Turner [this message]
2020-04-08 2:10 ` Brian Dolbec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEdQ38Edc2W5JESZXyAjzBq0oqufBCXT0xGEO76mECMnCAg1xw@mail.gmail.com \
--to=mattst88@gentoo.org \
--cc=antarus@gentoo.org \
--cc=gentoo-catalyst@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox