From: Matt Turner <mattst88@gentoo.org>
To: gentoo-catalyst@lists.gentoo.org
Subject: [gentoo-catalyst] [rfc] simplifying arch classes
Date: Mon, 27 Jun 2011 01:15:31 -0400 [thread overview]
Message-ID: <BANLkTikRAXECejd_6mmw_w3=7HCgGE-3NA@mail.gmail.com> (raw)
The arch class structure ({alpha,amd64,mips,hppa,etc}.py files) are a
lot of typing for the small number of attributes they synthesize. This
makes them prone to typing errors.
Consider mips.py. It supports big and little endian; mips 1, 3, 4,
loongson, cobalt; o32, n32, n64, multilib ABIs. Almost every
combination of these attributes exists as a hard-coded class, leaving
us with 24 builder and 5 abstract base classes.
Wouldn't it be simpler to pass in some information into an arch_mips
class and let it generate the requested attributes. Something like
this:
class arch_mips(generic):
"MIPS class"
def __init__(self, Olevel, arch, additional_cflags, include_workarounds):
generic.__init__(self)
self.settings["CFLAGS"] = "-O" + Olevel
self.settings["CFLAGS"] += " -march=" + arch
if additional_cflags != "":
self.settings["CFLAGS"] += " " + additional_cflags
if include_workarounds:
if arch == "mips3":
self.settings["CFLAGS"] += " -mfix-r4000 -mfix-r4400"
elif arch == "r4000" or arch == "r4k":
self.settings["CFLAGS"] += " -mfix-r4000"
elif arch == "r4300":
self.settings["CFLAGS"] += " -mfix-r4300"
elif arch == "r10000" or arch == "r10k":
self.settings["CFLAGS"] += " -mfix-r10000"
self.settings["CFLAGS"] += " -pipe"
Clearly a simplistic and incomplete example, but it should be enough
to understand the idea.
Thanks,
Matt
next reply other threads:[~2011-06-27 5:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-27 5:15 Matt Turner [this message]
2011-06-27 17:41 ` [gentoo-catalyst] [rfc] simplifying arch classes Sebastian Pipping
2011-06-27 17:58 ` Matt Turner
2011-06-27 18:18 ` Sebastian Pipping
2011-06-27 18:24 ` Matt Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTikRAXECejd_6mmw_w3=7HCgGE-3NA@mail.gmail.com' \
--to=mattst88@gentoo.org \
--cc=gentoo-catalyst@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox