public inbox for gentoo-catalyst@lists.gentoo.org
 help / color / mirror / Atom feed
From: Marco Gigante <m.gigante@nextworks.it>
To: gentoo-catalyst@lists.gentoo.org
Subject: [gentoo-catalyst] livecd_stage2 autoresume clear
Date: Mon, 11 Apr 2016 16:07:11 +0200	[thread overview]
Message-ID: <570BAF8F.6040809@nextworks.it> (raw)

[-- Attachment #1: Type: text/plain, Size: 544 bytes --]

Hi. I'm using catalyst to generate installcd-stage2-minimal with custom 
changes and packages.
I realized catalyst clears autoresume states once the iso image was 
successfully generated, regardless the fact I run catalyst with or 
without --clear-autoresume option.

Poking around the code, for my convenience I made the change as in the 
attached diff (vs. master branch).
Could such modification bring to unexpected behaviour?

I tried with all 2.X, 3.0, and master branches seeing the same behaviour.

Thanks in advance for any help.
marco

[-- Attachment #2: 0001-Set-autoresume-clear-option-dependent-for-livecd_sta.patch --]
[-- Type: text/x-patch, Size: 921 bytes --]

From 60458178bdbd3d18e4264a16641365b898880774 Mon Sep 17 00:00:00 2001
From: Marco Gigante <m.gigante@nextworks.it>
Date: Mon, 11 Apr 2016 15:23:31 +0200
Subject: [PATCH] Set autoresume clear option-dependent for livecd_stage2

---
 catalyst/targets/livecd_stage2.py |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/catalyst/targets/livecd_stage2.py b/catalyst/targets/livecd_stage2.py
index ea916b8..e1e7496 100644
--- a/catalyst/targets/livecd_stage2.py
+++ b/catalyst/targets/livecd_stage2.py
@@ -83,4 +83,5 @@ class livecd_stage2(StageBase):
 				"livecd_update","root_overlay","fsscript","rcupdate","unmerge",\
 				"unbind","remove","empty","target_setup",\
 				"setup_overlay","create_iso"]
-		self.settings["action_sequence"].append("clear_autoresume")
+		if "clear-autoresume" not in self.settings["options"]:
+			self.settings["action_sequence"].append("clear_autoresume")
-- 
1.7.9.5


             reply	other threads:[~2016-04-11 14:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-11 14:07 Marco Gigante [this message]
2016-04-11 17:39 ` [gentoo-catalyst] livecd_stage2 autoresume clear Brian Dolbec
2016-04-12  6:37   ` Marco Gigante

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570BAF8F.6040809@nextworks.it \
    --to=m.gigante@nextworks.it \
    --cc=gentoo-catalyst@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox